Conversation
seanpm2001
left a comment
There was a problem hiding this comment.
It looks good. However, on core/src/avm2/activation.rs on line 2288, there appears to be a unclosed parentheses. Is this type safe in Rust, or should this be fixed? Other than that, it looks pretty good.
|
The automatic tests passed, so there can't really be any syntactical errors in the code. |
|
Thank you for the reply. This helps clarify it for me. I was originally wondering how it passed the test with the syntax. Now I know why. I am just so used to the strict syntax in Python when it comes to whitespace and parentheses and most other programming languages requiring a paranthese to always have a closing paranthese. example: foo = str(input("Sample")) # Correct
bar = str(input("Sample") # IncorrectAlso, I used the word type safety, as I mistook it for a type of syntax error. I will try to get a better definition of type safety and just say "possible syntax error" from now on. |
|
I don't believe you should use the prototypes to check for XML/XMLList, here's a test: |
|
Thank you! |
This implements the TypeOf instruction for AVM2, to be able to fully test this I also needed to create a minimal stub for both XML and XMLList as these have a different result ("xml") compared to other objects ("object").