desktop: Fix gui scale on launch on wayland#15781
desktop: Fix gui scale on launch on wayland#15781torokati44 merged 1 commit intoruffle-rs:masterfrom
Conversation
|
Huh, I've never had this problem on KWin before. Can someone test on Windows please? X11 (via XWayland) is unaffected, has the correct windows size both before and after. |
|
Maybe this fixes #15157 though...? |
|
I'm not sure about #15157, the window is the same size, but the image seems to have less gross filtering.
Is there a proper pixel art swf you can point me to? |
I assume if you run it with |
|
Huh, weird. Not quite pixel art, but https://z0r.de/L/z0r-de_420.swf for example is relatively small, and should be pixelated (possibly due to #10103, but whatever). |
|
Yes, I see those requests. So maybe it's KWin who insists on this "factory-default" size too much? attila ~/projects/ruffle $ git checkout origin/master -f
HEAD is now at 9dfc6dc22 fix(deps): update rust dependencies
attila ~/projects/ruffle $ WAYLAND_DEBUG=1 cargo run -- 'https://z0r.de/L/z0r-de_420.swf' 2>&1 | grep -P 'xdg_toplevel@.*configure'
[2244621.129] xdg_toplevel@29.configure_bounds(1920, 1016)
[2244621.135] xdg_toplevel@29.configure(0, 0, array[0])
[2245301.342] xdg_toplevel@29.configure(800, 600, array[4])
[2245625.470] xdg_toplevel@29.configure(800, 600, array[4])
attila ~/projects/ruffle $ git checkout ColinKinloch/wl_resize_gui -f
Previous HEAD position was 9dfc6dc22 fix(deps): update rust dependencies
HEAD is now at 0cdde301a desktop: Fix gui scale on launch on wayland
attila ~/projects/ruffle $ WAYLAND_DEBUG=1 cargo run -- 'https://z0r.de/L/z0r-de_420.swf' 2>&1 | grep -P 'xdg_toplevel@.*configure'
[2287138.117] xdg_toplevel@29.configure_bounds(1920, 1016)
[2287138.120] xdg_toplevel@29.configure(0, 0, array[0])
[2287811.485] xdg_toplevel@29.configure(800, 600, array[4])
[2288157.708] xdg_toplevel@29.configure(800, 600, array[4])
attila ~/projects/ruffle $ |
|
This bug doesn't manifest if the swf is passed as an argument. I assume ruffle creates the windows/gui if it's already got the file. |
|
On my machine, it looks and behaves exactly the same way before and after this PR, no matter if I supply the SWF on the command line, or in the "Open" dialog. |
|
I had a look at it in a nested kwin instance. This is both on |
|
Yep, that's what I'm seeing too. Sad. |
|
Current nightly on Arch Plasma 6 seems to keep the regular 1x GUI scale. Or is it not supposed to stay at 1x? What's the test case that's supposed to trigger this? |
|
What I said about Plasma 6 is not a matter of GUI scale, simply window size not matching the content size (as opposed to being reset to 800x600). So these are two related, but not exactly the same, issues. |
0cdde30 to
75f6485
Compare
|
Ah, right, testing in Weston, I get this before (currently): It's hard to see, but the content matches the window in size just a little bit better! 😄 EDIT: Oh, sorry, this is basically #15781 (comment) ... How did I not realize...? |
75f6485 to
168b95e
Compare
168b95e to
37d7ae7
Compare










On platforms that support synchronous resizing such as wayland
request_inner_sizereturns the new window size and noWindowEvent::Resizeis generated (documented here).This MR resizes the gui if
request_inner_sizereturns a value different from its original value.