Skip to content

chore: Bump image to v0.25, without the dxt feature#15634

Merged
torokati44 merged 1 commit intoruffle-rs:masterfrom
torokati44:image-0.25
Mar 18, 2024
Merged

chore: Bump image to v0.25, without the dxt feature#15634
torokati44 merged 1 commit intoruffle-rs:masterfrom
torokati44:image-0.25

Conversation

@torokati44
Copy link
Copy Markdown
Member

I hope some visual tests will fail on this, at least on Windows.
To be fixed by an alternative implementation based on https://github.com/jansol/texpresso, as recommended.

@torokati44
Copy link
Copy Markdown
Member Author

Uuuuhm. Huhh. How does this still work, @Aaron1011 ? 🤔
Do we simply not have a visual test for DXT-compressed textures?
I have no idea how ATF actually works together with the different algorithms... :/

@Aaron1011
Copy link
Copy Markdown
Member

I added the dxt feature early on when working on compressed alpha support, but we don't actually use it - we produce a TIFF image from the jpegxr crate, and then decode that using the image crate.

@torokati44 torokati44 marked this pull request as ready for review March 18, 2024 22:58
@torokati44
Copy link
Copy Markdown
Member Author

Oooh, I see. Thanks for the explanation!
So we're actually always taking the "compatibility fallback" option out of the ATF, and pre-decompress it on the CPU for the sake of portability, instead of making use of the other GPU-friendly compressed alternatives in there?

@torokati44 torokati44 merged commit d9f17da into ruffle-rs:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants