5465 Remove "Saving" State to Allow Submit Buttons to Remain in Original State#5466
Merged
awwaiid merged 1 commit intorubyforgood:mainfrom Dec 16, 2025
Conversation
awwaiid
approved these changes
Dec 16, 2025
Collaborator
awwaiid
left a comment
There was a problem hiding this comment.
It seems like we're still missing something here on how to do this the proper way, but this'll get us unblocked.
Contributor
|
@janeewheatley: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 5465
Description
When creating or editing an audit, if duplicate items are detected and the modal is shown, dismissing the modal without merging (by clicking "Make Changes" or the X button) leaves the "Save Progress" and "Confirm Audit" buttons stuck in a disabled "Saving" state. Rails UJS automatically changes button text to "Saving" and disables buttons when form submission begins.
I disabled Rails UJS for the audit form as "Saving" didn't really make sense on these buttons in this context.
Type of change
How Has This Been Tested?
Screenshots