Fix issue where seed was intermittently failing part way through#5461
Merged
dorner merged 1 commit intorubyforgood:mainfrom Dec 2, 2025
Merged
Fix issue where seed was intermittently failing part way through#5461dorner merged 1 commit intorubyforgood:mainfrom
dorner merged 1 commit intorubyforgood:mainfrom
Conversation
…sing no transactions to be added .
dorner
approved these changes
Dec 2, 2025
Contributor
|
@cielf: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The seed was intermittently failing, causing there to be no transactions/history added to the organizations
Investigation revealed that the extra items added to the Second City bank were based on a random base item, and that if the base item it was based on had a null reporting category, the item would not be created. Later code fails unless there are 4 of these items.
This problem would go away eventually when we finish decoupling the items from base items, but in the meantime I have changed the collection of base items that the Second City Bank items are based on to only include the ones with a reporting category. We could set this back to "all" once we decouple items and base items.
Type of change
How Has This Been Tested?
I ran the seed several times without it failing.