Use dynamically-created repo for signed commits test#614
Merged
jcouball merged 1 commit intoFeb 5, 2023
Merged
Conversation
This replaces the test repo introduced in ruby-git#610 with one created on the fly in the test. I've switched from GPG to SSH signing to minimise the likelihood that we'll need extra dependencies on CI or other contributors' machines. I've also removed some of the commit metadata assertions that didn't feel particularly necessary, and this allowed me to reduce the setup steps for clarity. Signed-off-by: Simon Coffey <simon.coffey@futurelearn.com>
jcouball
approved these changes
Feb 5, 2023
jcouball
left a comment
Member
There was a problem hiding this comment.
10 less files AND your test is shorter! Nice!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
This replaces the test repo introduced in #610 with one created on the fly in the test.
I've switched from GPG to SSH signing to minimise the likelihood that we'll need extra dependencies on CI or other contributors' machines – if this fails on github actions then I'll look into whatever we need to get
ssh-keygenrunning there.I've also removed some of the commit metadata assertions that didn't feel particularly necessary, and this allowed me to reduce the setup steps for clarity.