Skip to content

Add a note: Separation of positional and keyword arguments in Ruby 3.0#2293

Merged
mame merged 1 commit intoruby:masterfrom
mame:separation-of-positional-and-keyword-arguments-in-ruby-3-0
Dec 13, 2019
Merged

Add a note: Separation of positional and keyword arguments in Ruby 3.0#2293
mame merged 1 commit intoruby:masterfrom
mame:separation-of-positional-and-keyword-arguments-in-ruby-3-0

Conversation

@mame
Copy link
Copy Markdown
Member

@mame mame commented Dec 3, 2019

No description provided.

@mame mame requested a review from a team as a code owner December 3, 2019 10:01
sorah
sorah reviewed Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@sorah sorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some readability/grammar comments but note that I'm not a native speaker. You may apply the suggestions or may not.

@mame
Copy link
Copy Markdown
Member Author

mame commented Dec 3, 2019

@sorah Thank you very much for your review!

jeremyevans
jeremyevans reviewed Dec 4, 2019
View reviewed changes
XrXr
XrXr reviewed Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@XrXr XrXr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions for sentences that I found to be weird. I am also not a native speaker, so please take these suggestions with a grain of salt.

@eregon
Copy link
Copy Markdown
Member

eregon commented Dec 6, 2019 •
edited
Loading

The section about delegation looks good. However I would like to see some mention of when ruby2_keywords will be removed and what code can be used to work on 2.6 and after it's removed.

@jeremyevans
Copy link
Copy Markdown
Contributor

jeremyevans commented Dec 6, 2019

The section about delegation looks good. However I would like to see some mention of when ruby2_keywords will be removed and what code can be used to work on 2.6 and after it's removed.

I don't think there has been a decision on that. There is a tentative idea of after 2.6 EOL. At that point, we should not concern ourselves with 2.6 compatibility. We could say that when/if ruby2_keywords is removed in the future, you could switch to explicit keyword argument forwarding.

My personal opinion is that ruby2_keywords should stay until both of the following are true:

  • 2.6 is EOL.
  • Explicitly forwarding keyword arguments is not slower than using ruby2_keywords in CRuby.

@eregon
Copy link
Copy Markdown
Member

eregon commented Dec 12, 2019 •
edited
Loading

We could say that when/if ruby2_keywords is removed in the future, you could switch to explicit keyword argument forwarding.

I would be fine with that.
But currently nothing is said and I feel it's dishonest to show a solution (ruby2_keywords), which therefore pretends it will stay forever when it's not been decided yet and likely will not stay forever.

I added a suggested change to mention that.

mame added a commit to mame/www.ruby-lang.org that referenced this pull request Dec 12, 2019
@mame
Add Sorah's suggestion
443620a 
ruby#2293 (comment)
@mame
Copy link
Copy Markdown
Member Author

mame commented Dec 13, 2019

Thank you for your review and comments! I really appreciate you all.

The commit log in this PR seems too long to make CI fail :-) I'll squash the commits, and merge it soon.

Even after this article is published, we can modify it with history.

@mame mame force-pushed the separation-of-positional-and-keyword-arguments-in-ruby-3-0 branch from 432e451 to c57a5c3 Compare December 13, 2019 00:52
@mame mame force-pushed the separation-of-positional-and-keyword-arguments-in-ruby-3-0 branch from c57a5c3 to f079d22 Compare December 13, 2019 01:01
@mame mame changed the title [WIP] Add a note: Separation of positional and keyword arguments in Ruby 3.0 Add a note: Separation of positional and keyword arguments in Ruby 3.0 Dec 13, 2019
@mame mame merged commit cb1ec95 into ruby:master Dec 13, 2019
@mame mame deleted the separation-of-positional-and-keyword-arguments-in-ruby-3-0 branch December 13, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyevans jeremyevans jeremyevans left review comments

@sorah sorah sorah left review comments

+2 more reviewers

@eregon eregon eregon left review comments

@XrXr XrXr XrXr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mame @eregon @jeremyevans @sorah @XrXr