#1142 but with an extra commit to ease reviewing the diff#1143
Closed
eregon wants to merge 2 commits intoruby:masterfrom
Closed
#1142 but with an extra commit to ease reviewing the diff#1143eregon wants to merge 2 commits intoruby:masterfrom
eregon wants to merge 2 commits intoruby:masterfrom
Conversation
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step. Co-authored-by: Benoit Daloze <eregontp@gmail.com>
…ce_encoding * With: replace "'.dup.force_encoding" "'.force_encoding" -- $(git ls-files) replace '".dup.force_encoding' '".force_encoding' -- $(git ls-files)
| describe "StringIO#reopen when passed no arguments" do | ||
| before :each do | ||
| @io = StringIO.new("example\nsecond line") | ||
| @io = StringIO.new(+"example\nsecond line") |
Member
There was a problem hiding this comment.
Seems this change isn't needed (checked with Ruby 3.2.2)
Member
Author
There was a problem hiding this comment.
OK, could you fix this in a PR?
| @io.reopen(obj) | ||
| @io.string.should == "to_strio" | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
Seems changes in this describe block aren't needed. And probably in some cases above as well.
Member
Author
There was a problem hiding this comment.
OK, could you fix this in a PR?
eregon
commented
Mar 15, 2024
Member
Author
eregon
left a comment
There was a problem hiding this comment.
Thanks for the review! Could you do a PR with the remaining changes? I marked as resolved what can stay as-is.
Member
|
Yes, will work on the remaining issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1142 but with an extra commit to ease reviewing the diff.