Fix Marshal and dumping String in a multibyte encoding

andrykonchin · eregon · commit 907cb35e2106 · 2023-04-25T16:37:32.000+02:00
diff --git a/core/marshal/dump_spec.rb b/core/marshal/dump_spec.rb
@@ -193,6 +193,11 @@ def _dump(level)
       Marshal.dump(MarshalSpec::ClassWithOverriddenName).should == "\x04\bc)MarshalSpec::ClassWithOverriddenName"
     end
 
+    it "dumps a class with multibyte characters in name" do
+      source_object = eval("MarshalSpec::MultibyteぁあぃいClass".force_encoding(Encoding::UTF_8))
+      Marshal.dump(source_object).should == "\x04\bc,MarshalSpec::Multibyte\xE3\x81\x81\xE3\x81\x82\xE3\x81\x83\xE3\x81\x84Class"
+    end
+
     it "raises TypeError with an anonymous Class" do
       -> { Marshal.dump(Class.new) }.should raise_error(TypeError, /can't dump anonymous class/)
     end
@@ -211,6 +216,11 @@ def _dump(level)
       Marshal.dump(MarshalSpec::ModuleWithOverriddenName).should == "\x04\bc*MarshalSpec::ModuleWithOverriddenName"
     end
 
+    it "dumps a module with multibyte characters in name" do
+      source_object = eval("MarshalSpec::MultibyteけげこごModule".force_encoding(Encoding::UTF_8))
+      Marshal.dump(source_object).should == "\x04\bm-MarshalSpec::Multibyte\xE3\x81\x91\xE3\x81\x92\xE3\x81\x93\xE3\x81\x94Module"
+    end
+
     it "raises TypeError with an anonymous Module" do
       -> { Marshal.dump(Module.new) }.should raise_error(TypeError)
     end
@@ -673,6 +683,11 @@ def finalizer.noop(_)
       Marshal.dump(obj).should include("MarshalSpec::TimeWithOverriddenName")
     end
 
+    it "dumps a Time subclass with multibyte characters in name" do
+      source_object = eval("MarshalSpec::MultibyteぁあぃいTime".force_encoding(Encoding::UTF_8))
+      Marshal.dump(source_object).should == "\x04\bc+MarshalSpec::Multibyte\xE3\x81\x81\xE3\x81\x82\xE3\x81\x83\xE3\x81\x84Time"
+    end
+
     it "raises TypeError with an anonymous Time subclass" do
       -> { Marshal.dump(Class.new(Time).now) }.should raise_error(TypeError)
     end
diff --git a/core/marshal/fixtures/marshal_data.rb b/core/marshal/fixtures/marshal_data.rb
@@ -262,6 +262,17 @@ def self.name
     end
   end
 
+  module_eval(<<~ruby.force_encoding(Encoding::UTF_8))
+    class MultibyteぁあぃいClass
+    end
+
+    module MultibyteけげこごModule
+    end
+
+    class MultibyteぁあぃいTime < Time
+    end
+  ruby
+
   DATA = {
     "nil" => [nil, "\004\b0"],
     "1..2" => [(1..2),
