Skip to content

Consider BUNDLE_ONLY in cache key #531

@r7kamura

Description

@r7kamura

BUNDLE_ONLY has been added since bundler 2.3.19.

I think this value should be included in the cache key as well as BUNDLE_WITH and BUNDLE_WITHOUT, what do you think?

setup-ruby/bundler.js

Lines 235 to 239 in 52b8784

async function computeBaseKey(platform, engine, version, lockFile, cacheVersion) {
const cwd = process.cwd()
const bundleWith = process.env['BUNDLE_WITH'] || ''
const bundleWithout = process.env['BUNDLE_WITHOUT'] || ''
let key = `setup-ruby-bundler-cache-v6-${common.getOSNameVersionArch()}-${engine}-${version}-wd-${cwd}-with-${bundleWith}-without-${bundleWithout}`

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions