Make Base64.urlsafe methods actually urlsafe.#815
Make Base64.urlsafe methods actually urlsafe.#815dragonsinth wants to merge 2 commits intoruby:trunkfrom dragonsinth:10740
Conversation
|
Looks good to me based on https://tools.ietf.org/html/rfc4648#section-5 and the "padding" section of http://en.wikipedia.org/wiki/Base64 A strict reading of RFC4648 (section 3.2 in particular) might imply that one should allow the caller of these methods to decide whether they want to generate/require padding, but in the urlsafe case it seems better to omit padding, since including it defeats the point of making the encoding urlsafe. |
|
+1 |
1 similar comment
|
👍 |
|
Pushed a change, waiting for CI. I don't actually know how to run the tests locally. :/ |
|
Travis doesn't run the unit tests. |
|
Thanks so much, |
|
merged at 6b66809 |
https://bugs.ruby-lang.org/issues/10740