Skip to content

Make Base64.urlsafe methods actually urlsafe.#815

Closed
dragonsinth wants to merge 2 commits intoruby:trunkfrom
dragonsinth:10740
Closed

Make Base64.urlsafe methods actually urlsafe.#815
dragonsinth wants to merge 2 commits intoruby:trunkfrom
dragonsinth:10740

Conversation

@dragonsinth
Copy link
Copy Markdown

@jkingdon
Copy link
Copy Markdown

Looks good to me based on https://tools.ietf.org/html/rfc4648#section-5 and the "padding" section of http://en.wikipedia.org/wiki/Base64

A strict reading of RFC4648 (section 3.2 in particular) might imply that one should allow the caller of these methods to decide whether they want to generate/require padding, but in the urlsafe case it seems better to omit padding, since including it defeats the point of making the encoding urlsafe.

@danielribeiro
Copy link
Copy Markdown

+1

1 similar comment
@chriseckhardt
Copy link
Copy Markdown

👍

@dragonsinth
Copy link
Copy Markdown
Author

Pushed a change, waiting for CI. I don't actually know how to run the tests locally. :/

@drbrain
Copy link
Copy Markdown
Member

drbrain commented Jan 16, 2015

Travis doesn't run the unit tests. make test for all tests, make test TESTS=subdir to run just the tests in that subdirectory IIRC, make help should say

@dragonsinth
Copy link
Copy Markdown
Author

Thanks so much, make test-all TESTS=test/base64 did it for me. Should be good to go now.

@dragonsinth
Copy link
Copy Markdown
Author

@mame

@hsbt
Copy link
Copy Markdown
Member

hsbt commented Feb 17, 2015

merged at 6b66809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants