Implement Write Barrier for autoload_data#7392
Merged
byroot merged 1 commit intoruby:masterfrom Feb 28, 2023
Merged
Conversation
It's not uncommon for libraries to add thing sinto autoload that won't necessarily be loaded. This can cause hundreds or thousands of entries to be left over in the autoload table, so it's best not to mark them on every minor.
ad8fb71 to
813c3f2
Compare
Member
peterzhu2118
left a comment
There was a problem hiding this comment.
I think we should also make autoload_table_type WB protected since most (if not all) autoload_data_type should have a autoload_table_type.
If we do that, we also need a write barrier when adding a node in autoload_data->constants in autoload_synchronized.
Contributor
Author
|
Yeah, I'm trying to take baby steps :) |
peterzhu2118
approved these changes
Feb 27, 2023
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not uncommon for libraries to add thing sinto autoload that won't necessarily be loaded.
This can cause hundreds or thousands of entries to be left over in the autoload table, so it's best not to mark them on every minor.
autoload_constis in the same situation, but is a bit harder to implement Write Barriers for as its sometimes updated from callbacks that don't have access to theVALUE.cc @peterzhu2118