Skip to content

YJIT: Avoid creating payloads for non-JITed ISEQs#6549

Merged
k0kubun merged 2 commits intoruby:masterfrom
Shopify:yjit-lazy-payload
Oct 14, 2022
Merged

YJIT: Avoid creating payloads for non-JITed ISEQs#6549
k0kubun merged 2 commits intoruby:masterfrom
Shopify:yjit-lazy-payload

Conversation

@k0kubun
Copy link
Member

@k0kubun k0kubun commented Oct 14, 2022

  • Add freed_iseq_count counter for evaluating a potential impact of code GC
  • Avoid creating payloads for non-JITed ISEQs to avoid false counting

Prior to this PR, compiled_iseq_count had a false counting problem. Here's the counters corrected by this PR on railsbench:

before

compiled_iseq_count:         5660
freed_iseq_count:            1937

after

compiled_iseq_count:         2717
freed_iseq_count:              69

@matzbot matzbot requested a review from a team October 14, 2022 18:54
@k0kubun k0kubun merged commit 53e0e5e into ruby:master Oct 14, 2022
@k0kubun k0kubun deleted the yjit-lazy-payload branch October 14, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants