thread_sync.c: Clarify and document the behavior of timeout == 0#6500
Merged
byroot merged 1 commit intoruby:masterfrom Oct 17, 2022
Merged
thread_sync.c: Clarify and document the behavior of timeout == 0#6500byroot merged 1 commit intoruby:masterfrom
byroot merged 1 commit intoruby:masterfrom
Conversation
Member
|
Seems OK to me. |
Contributor
Author
Indeed, I guess it wouldn't cost much to test for it as well. I can add it. |
Member
|
I think the correct thing to do here would be to coerce first (Fixnum or use |
cef3151 to
12bb555
Compare
casperisfine
commented
Oct 6, 2022
| rb_raise(rb_eThreadError, "queue empty"); | ||
| } | ||
|
|
||
| if (RTEST(rb_equal(INT2FIX(0), timeout))) { |
Member
There was a problem hiding this comment.
That should work, except if it's a custom object with to_f. Probably good enough.
[Feature #18982] Instead of introducing an `exception: false` argument to have `non_block` return nil rather than raise, we can clearly document that a timeout of 0 immediately returns. The code is refactored a bit to avoid doing a time calculation in such case.
12bb555 to
dfdc752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Feature #18982]
Instead of introducing an
exception: falseargument to havenon_blockreturn nil rather than raise, we can clearly document that a timeout of 0 immediately returns.The code is refactored a bit to avoid doing a time calculation in such case.
cc @ko1 @eregon