Make method id explicit in rb_exec_recursive_outer#6004
Merged
jhawthorn merged 2 commits intoruby:masterfrom Jun 10, 2022
Merged
Make method id explicit in rb_exec_recursive_outer#6004jhawthorn merged 2 commits intoruby:masterfrom
jhawthorn merged 2 commits intoruby:masterfrom
Conversation
Previously, because opt_aref and opt_aset don't push a frame, when they would call rb_hash to determine the hash value of the key, the initial level of recursion would incorrectly use the method id at the top of the stack instead of "hash". This commit replaces rb_exec_recursive_outer with rb_exec_recursive_outer_mid, which takes an explicit method id, so that we can make the hash calculation behave consistently. rb_exec_recursive_outer was documented as being internal, so I believe this should be okay to change.
Member
|
BTW according to https://doxygen.nl/manual/commands.html#cmdinternal the |
Member
Author
|
@shyouhei thank you for the clarification I didn't realize 😳. I wasn't able to find any uses of this method outside of CRuby, but since it is public it should be easy to restore and I'll do that tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, because
opt_arefandopt_asetdon't push a frame, when they would callrb_hashto determine the hash value of the key, the initial level of recursion would incorrectly use the method id at the top of the stack instead of "hash".This commit replaces
rb_exec_recursive_outerwithrb_exec_recursive_outer_mid, which takes an explicit method id, so that we can make the hash calculation behave consistently.rb_exec_recursive_outerwas documented as being internal, so I believe this should be okay to change.