WIP: Try to add a fake frame when iseq compilation#5998
Closed
casperisfine wants to merge 1 commit intoruby:masterfrom
Closed
WIP: Try to add a fake frame when iseq compilation#5998casperisfine wants to merge 1 commit intoruby:masterfrom
casperisfine wants to merge 1 commit intoruby:masterfrom
Conversation
0458c05 to
9184e53
Compare
9184e53 to
7178182
Compare
Contributor
Author
|
Another limitation is that for now it doesn't work with cached iseqs loaded with |
Contributor
Author
|
Closing in favor of #6057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/18559
When tracing allocations, all the objects created by the compiler are attributed to
Kernel.require, making it impossible to measure the static overhead of various parts of an application.I paired on this with @peterzhu2118, we found a way to push a stack frame before an iseq is compiled, allowing
TracePointto report the rightsourcefile.We haven't however figured a way to set the line number, so all these allocations are reported on line
0.