Ractor.make_shareable checks proc's self#5232
Merged
ko1 merged 1 commit intoruby:masterfrom Dec 9, 2021
Merged
Conversation
eregon
approved these changes
Dec 8, 2021
Member
eregon
left a comment
There was a problem hiding this comment.
I think this is the correct thing to do, and by far the easiest to understand semantics: can only make shareable by making deeply immutable, or special always-shared values (Module, Ractor).
Member
|
Convenience for |
Ractor.make_shareable checks proc's seflRactor.make_shareable checks proc's self
`Ractor.make_shareable(proc_obj)` raises an `IsolationError` if the self of `proc_obj` is not a shareable object. [Bug #18243]
d243350 to
2345042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ractor.make_shareable(proc_obj)raises anIsolationErrorif the self of
proc_objis not a shareable object.[Bug #18243]