Improve Base64.urlsafe_encode64 performance#4802
Closed
jcmfernandes wants to merge 1 commit into
Closed
Conversation
str.delete!("=") iterates over the entire string looking for the equals
character, but we know that we will, at most, find 2 at the end of the
string.
Contributor
|
Can you please submit this upstream to https://github.com/ruby/base64? |
Contributor
Author
|
Some benchmarks: Input generated with |
Contributor
Author
Absolutely! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
str.delete!("=") iterates over the entire string looking for the equals
character, but we know that we will, at most, find 2 at the end of the
string.