Skip to content

Skip a File.atime test randomly failing on Travis ppc64le.#4546

Merged
junaruga merged 1 commit intoruby:masterfrom
junaruga:wip/skip-travis-ppc64le-atime
Jun 2, 2021
Merged

Skip a File.atime test randomly failing on Travis ppc64le.#4546
junaruga merged 1 commit intoruby:masterfrom
junaruga:wip/skip-travis-ppc64le-atime

Conversation

@junaruga
Copy link
Member

@junaruga junaruga commented Jun 2, 2021

Skip the test for now to pass the ppc64le.

See https://bugs.ruby-lang.org/issues/17926.

I checked it is skipped intentionally on my local like this.

$ TRAVIS=true TRAVIS_CPU_ARCH=foo make test-spec SPECOPTS=spec/ruby/core/file/atime_spec.rb
...   
1 file, 5 examples, 5 expectations, 0 failures, 0 errors, 0 tagged


$ TRAVIS=true TRAVIS_CPU_ARCH=ppc64le make test-spec SPECOPTS=spec/ruby/core/file/atime_spec.rb
...
1 file, 5 examples, 4 expectations, 0 failures, 0 errors, 0 tagged

@junaruga
Copy link
Member Author

junaruga commented Jun 2, 2021

The make test-all is failing on the MinGW CI case. But it is not related to this PR.
https://github.com/ruby/ruby/pull/4546/checks?check_run_id=2726427748

@junaruga junaruga merged commit 2048dfc into ruby:master Jun 2, 2021
@junaruga junaruga deleted the wip/skip-travis-ppc64le-atime branch June 2, 2021 10:38
eregon
eregon reviewed Jun 2, 2021
View reviewed changes
spec/ruby/core/file/atime_spec.rb
# https://bugs.ruby-lang.org/issues/17926
if ENV.key?('TRAVIS') && ENV['TRAVIS_CPU_ARCH'] == 'ppc64le'
skip '[ruby-core:17926] A random failure on Travis ppc64le'
end
Copy link
Member

@eregon eregon Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use platform_is_not below the platform_is :linux, :windows do above.
I guess it's an issue of linux-ppc64le (utimes(2) seems to ignore microseconds), not something specific to TravisCI.

Copy link
Member

@eregon eregon Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that in ruby/spec@2168fda

Copy link
Member Author

@junaruga junaruga Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eregon oh thanks! But I have observed this failure on only Travis' ppc64le. I have not observed it on RubyCI's "ppc64le (Ubuntu)" server on https://rubyci.org/. I wanted to show the situation.

Copy link
Member Author

@junaruga junaruga Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not want to hide the failure unnecessarily on other environments.

Copy link
Member

@eregon eregon Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. IMHO it doesn't matter too much, it's OK to platform_is_not when some subset of the runs don't work, especially for exotic platforms. Probably it's something to do with the OS/kernel version in this case, and that's probably too much trouble to guard to be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eregon eregon eregon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junaruga @eregon