Skip to content

Fix wrong RegExp.#2933

Merged
nobu merged 1 commit intoruby:masterfrom
voxik:install-expanded-gems-again
Feb 28, 2020
Merged

Fix wrong RegExp.#2933
nobu merged 1 commit intoruby:masterfrom
voxik:install-expanded-gems-again

Conversation

@voxik
Copy link
Copy Markdown
Contributor

@voxik voxik commented Feb 27, 2020

The missing \ in PR #2922 causes the default gems to be installed from the .gem packages instead from the expanded sources.

The missing `\` in PR ruby#2922 causes the default gems to be installed from
the .gem packages instead from the expanded sources.
@deivid-rodriguez
Copy link
Copy Markdown
Contributor

I noticed the same bug yesterday and proposed the same fix in #2930.

@voxik
Copy link
Copy Markdown
Contributor Author

voxik commented Feb 27, 2020

Ah, thx for the heads up. I am fine if yours is merged/cherry-picked first. You probably want to reference it here ;) https://bugs.ruby-lang.org/issues/16656

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

I'm fine either way, as long as we get this fixed :)

@nobu nobu merged commit 9bede6e into ruby:master Feb 28, 2020
@deivid-rodriguez deivid-rodriguez mentioned this pull request Feb 28, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants