Skip to content

Stop setting jobs argument "make -jN" for Travis arm64.#2642

Closed
junaruga wants to merge 2 commits into
ruby:masterfrom
junaruga:feature/travis-ci-arm64-add-debug
Closed

Stop setting jobs argument "make -jN" for Travis arm64.#2642
junaruga wants to merge 2 commits into
ruby:masterfrom
junaruga:feature/travis-ci-arm64-add-debug

Conversation

@junaruga

@junaruga junaruga commented Nov 4, 2019

Copy link
Copy Markdown
Member

This PR is pointed out by https://bugs.ruby-lang.org/issues/16234 .

To investigate this issue https://travis-ci.org/ruby/ruby/jobs/606916890#L2412 .

Using "false instead of "exit 1" Because it causes "No output has been received in the last 10m0s".
See https://travis-ci.community/t/exit-0-cannot-exit-successfully-on-arm/5731

I do not intend this PR is merged.

@junaruga junaruga force-pushed the feature/travis-ci-arm64-add-debug branch 3 times, most recently from 389717d to 58c8e5d Compare November 7, 2019 20:03
A default JOBS value is
* "-j3" in Travis x86_64
* "-j33" in Travis arm64

Because when following task in each ext/*/Makefile can be executed
without an exclusive lock from exts.mk by "make -s -jN",
.RUBYCOMMONDIR.time file can be newer than some .ext/common/*.rb files.
This causes "Permission defined" error like https://travis-ci.org/ruby/ruby/jobs/606916890#L2412 .

ext/*/Makefile

```
$(TIMESTAMP_DIR)/.RUBYCOMMONDIR.time:
    $(Q) $(MAKEDIRS) $(@d) $(RUBYLIBDIR)
    $(Q) $(TOUCH) $@
```

Remove the debugging code for Mac OSX case. It might be same cause.
@junaruga junaruga force-pushed the feature/travis-ci-arm64-add-debug branch from e19581e to 7e4b40b Compare November 8, 2019 17:22
@junaruga junaruga changed the title Add debugging logic for "make install" on arm64. Stop setting jobs argument "make -jN" for Travis arm64. Nov 8, 2019
@junaruga

Copy link
Copy Markdown
Member Author

If we pass the arm64 case as an temporary workflow without lowering the performance, just set make COPY='cp -f' install passes the steps. Maybe.

if [ "$(uname -m)" = aarch64 ]; then
  make COPY='cp -f' install
else
  make install
fi

@junaruga

Copy link
Copy Markdown
Member Author

Close this ticket, because of the better solution: #2669 .

@junaruga junaruga closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant