Fix case/in parsing of standalone "in" pattern matching#16256
Closed
knu wants to merge 1 commit intoruby:masterfrom
Closed
Fix case/in parsing of standalone "in" pattern matching#16256knu wants to merge 1 commit intoruby:masterfrom
knu wants to merge 1 commit intoruby:masterfrom
Conversation
|
The following files are maintained in the following upstream repositories:
Please file a pull request to the above instead. Thank you! |
This comment has been minimized.
This comment has been minimized.
9985866 to
c2acfd1
Compare
Fixes [Bug #21925]
c2acfd1 to
a1dcbea
Compare
kddnewton
requested changes
Mar 2, 2026
Contributor
kddnewton
left a comment
There was a problem hiding this comment.
I agree this fixes the problem, but this is an incredibly specific fix inside of the most generic possible place, so this is going to impact parsing times of every file. I would much rather fix this inside the place where we handle the in keyword.
Member
Author
|
True, feel free to push a better fix instead. |
Contributor
|
Sure. ruby/prism#3948 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [Bug #21925]