Fix rb_interned_str: create strings with BINARY (akak ASCII_8BIT) encoding#15888
Merged
byroot merged 1 commit intoruby:masterfrom Jan 16, 2026
Merged
Fix rb_interned_str: create strings with BINARY (akak ASCII_8BIT) encoding#15888byroot merged 1 commit intoruby:masterfrom
byroot merged 1 commit intoruby:masterfrom
Conversation
eregon
approved these changes
Jan 16, 2026
Member
|
Did you intend to update all the internal references to ASCII? We're also using this for encoding names via |
Member
Author
|
I did yes, but I only checked for |
cbd31d7 to
ff60414
Compare
…oding [Bug #21842] The documentation always stated as much, and it's consistent with the rb_str_* family of functions.
ff60414 to
a54b1e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Bug #21842]
The documentation always stated as much, and it's consistent with the rb_str_* family of functions.