Don't declare rbimpl_check_typeddata as pure#15467
Merged
byroot merged 1 commit intoruby:masterfrom Dec 9, 2025
Merged
Conversation
[Bug #21771] It may raise so it's incorrect and can lead to the compiler optimizing the call out.
jeremyevans
approved these changes
Dec 9, 2025
Member
For my understanding, if the compiler optimizes it out then I guess the compiler has proven it's the fast-path, in that case why is the behavior incorrect? |
Member
Author
|
No the problem was that It wouldn't have been possible if the return value was used. |
Member
Author
|
Here's the call that was optimized out: https://github.com/ged/ruby-pg/blob/bc3f2f8b1110e9bcb225d65554e1a7fc842d0506/ext/pg_connection.c#L1398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Bug #21771]
It may raise so it's incorrect and can lead to the compiler optimizing the call out.