Allow String#strip etc. to take optional chars to be stripped#15400
Merged
shugo merged 5 commits intoruby:masterfrom Dec 11, 2025
Merged
Allow String#strip etc. to take optional chars to be stripped#15400shugo merged 5 commits intoruby:masterfrom
shugo merged 5 commits intoruby:masterfrom
Conversation
nobu
reviewed
Dec 4, 2025
Member
nobu
left a comment
There was a problem hiding this comment.
I think it's worth to describe/test chars argument is interpreted like the argument of tr.
Member
Author
I've added documentation and tests in a9ad440. |
nobu
approved these changes
Dec 4, 2025
79d0dbb to
38d8763
Compare
[Feature #21552] Co-Authored-By: Claude <noreply@anthropic.com>
df98ac0 to
4414409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Feature #21552]