Register internal OBJSPACE tracepoints globally#15396
Merged
jhawthorn merged 3 commits intoruby:masterfrom Dec 9, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
e3c967e to
c3946a7
Compare
This solution is not quite correct because it doesn't solve multiple Ractors subscribing to the same event, but this will avoid unrelated events clobbering the flags for other events. This however will work corretly for subscribing to global ObjectSpace GC events.
c3946a7 to
74dcadb
Compare
Internal tracepoints only make sense to run globally, and they already took completely different paths.
74dcadb to
534d7d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal tracepoints only make sense to run globally, and they already took completely different paths.
This also fixes an issue where we would clear trace event flags when a Ractor exited (https://bugs.ruby-lang.org/issues/19112) whether or not they were ever used by the Ractor. This PR doesn't completely solve the issue, but does mitigate it in most (but not all) cases. This should probably be combined with #7184, which fixes multiple Ractors subscribing to the same events.