Define Kernel#instance_variables_to_inspect#15345
Merged
byroot merged 1 commit intoruby:masterfrom Nov 28, 2025
Merged
Conversation
b702c99 to
22d85e6
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Doesn't the code expect that the |
[Bug #21718]
Otherwise objects that don't define it, but define a fairly liberal
`method_missing` method will run into errors that are hard to understand:
```ruby
class Foo
def method_missing(name, ...)
name
end
end
p Foo.new.inspect
```
```
'Kernel#inspect': wrong argument type Symbol (expected Array) (TypeError)
from ../test.rb:7:in '<main>'
```
22d85e6 to
4b81bd2
Compare
Contributor
|
I haven't looked too closely at this yet, but spotted one bit of awkwardness with this change: Triggered in our app by a delegator inside aws-sdk-core getting stubbed with mocha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Bug #21718]
Otherwise objects that don't define it, but define a fairly liberal
method_missingmethod will run into errors that are hard to understand: