ZJIT: Remove unused self_val from HIR Send and InvokeSuper HIRs#14490
Merged
k0kubun merged 2 commits intoruby:masterfrom Sep 10, 2025
Merged
ZJIT: Remove unused self_val from HIR Send and InvokeSuper HIRs#14490k0kubun merged 2 commits intoruby:masterfrom
self_val from HIR Send and InvokeSuper HIRs#14490k0kubun merged 2 commits intoruby:masterfrom
Conversation
4c7e81c to
2a84433
Compare
k0kubun
approved these changes
Sep 10, 2025
Member
k0kubun
left a comment
There was a problem hiding this comment.
Could you resolve the conflict please?
2a84433 to
5b13529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not causing any issues but IMO if we're not using a HIR field (in codegen, optimization...etc.) then it's better to avoid having it for now to avoid confusion.