ZJIT: Support invokebuiltin opcodes#13632
Merged
k0kubun merged 1 commit intoruby:masterfrom Jun 18, 2025
Merged
Conversation
cc65b77 to
2dea571
Compare
tekknolagi
reviewed
Jun 18, 2025
tekknolagi
reviewed
Jun 18, 2025
* `invokebuiltin` * `invokebuiltin_delegate` * `invokebuiltin_delegate_leave` These instructions all call out to a C function, passing EC, self, and some number of arguments. `invokebuiltin` gets the arguments from the stack, whereas the `_delegate` instructions use a subset of the locals. `opt_invokebuiltin_delegate_leave` has a fast path for `leave`, but I'm not sure we need to do anything special for that here (FWIW YJIT appears to treat the two delegate instructions the same).
2dea571 to
e3fe5fc
Compare
k0kubun
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invokebuiltininvokebuiltin_delegateinvokebuiltin_delegate_leaveThese instructions all call out to a C function, passing EC, self, and some number of arguments.
invokebuiltingets the arguments from the stack, whereas the_delegateinstructions use a subset of the locals.opt_invokebuiltin_delegate_leavehas a fast path forleave, but I'm not sure we need to do anything special for that here (FWIW YJIT appears to treat the two delegate instructions the same).