[DOC] Tweaks for String#==#13323
Merged
peterzhu2118 merged 2 commits intoruby:masterfrom May 14, 2025
BurdetteLamar:rb_str_equal_doc
Merged
[DOC] Tweaks for String#==#13323peterzhu2118 merged 2 commits intoruby:masterfrom BurdetteLamar:rb_str_equal_doc
peterzhu2118 merged 2 commits intoruby:masterfrom
BurdetteLamar:rb_str_equal_doc
Conversation
string.c
Outdated
Comment on lines
+4567
to
+4568
| * If +object+ is not a string but responds to method <tt>to_str</tt>, | ||
| * the comparison is <tt>self == object.to_str</tt>. |
Member
There was a problem hiding this comment.
The behaviour is confusing, but this is not correct. If object responds to to_str, it DOES NOT call it, but rather calls object == self. If object does not respond to to_str, it just returns false.
For example:
class HasToStr
def to_str
raise
end
def ==(other)
puts "HasToStr: comparing to #{other}"
true
end
end
class DoesNotHaveToStr
def ==(other)
puts "DoesNotHaveToStr: comparing to #{other}"
true
end
end
puts "hello" == HasToStr.new
# => HasToStr: comparing to hello
# => true
puts "hello" == DoesNotHaveToStr.new
# => false
peterzhu2118
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.