YJIT: Split the block on optimized getlocal/setlocal#13282
Merged
k0kubun merged 3 commits intoruby:masterfrom May 12, 2025
Merged
YJIT: Split the block on optimized getlocal/setlocal#13282k0kubun merged 3 commits intoruby:masterfrom
k0kubun merged 3 commits intoruby:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
XrXr
reviewed
May 9, 2025
Member
from https://github.com/ruby/ruby/actions/runs/14914047749/job/41898153221?pr=13282 No other message, and I haven't seen this symptom recently. Possibly uncovered by this change. |
Member
Author
Addressing #13282 (comment) with b4c207a seems to have removed the symptom on this PR's CI. Note that it has happened on master too: |
maximecb
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a more generalized fix than #13245 to the problem the PR addressed.
It splits the block when getlocal or setlocal is optimized and thus needs to be invalidated when EP escapes. I'd like to still keep #13245 because send instructions are highly polymorphic, so it's generally nice to share the successor blocks.