Skip to content

Array#fetch_values: expand ranges#12565

Open
byroot wants to merge 1 commit intoruby:masterfrom
byroot:array-fetch-values-range
Open

Array#fetch_values: expand ranges#12565
byroot wants to merge 1 commit intoruby:masterfrom
byroot:array-fetch-values-range

Conversation

@byroot
Copy link
Copy Markdown
Member

@byroot byroot commented Jan 13, 2025 •
edited
Loading

[Feature #20953]

This tries to implement the range expansion like desired by Matz.

However I don't know how to handle some edge cases such as endless ranges.

@launchable-app
Copy link
Copy Markdown

launchable-app bot commented Jan 13, 2025 •
edited
Loading

❌ 3/32414 Tests Failed

test/rubygems/test_gem_safe_marshal.rb#test_negative_length 
Failure:
TestGemSafeMarshal#test_negative_length [/Users/runner/work/ruby/ruby/src/test/rubygems/test_gem_safe_marshal.rb:454]:
IndexError expected but nothing was raised.
test/ruby/test_array.rb#test_fetch 
Failure:
TestArraySubclass#test_fetch [/Users/runner/work/ruby/ruby/src/test/ruby/test_array.rb:2689]:
IndexError expected but nothing was raised.
test/ruby/test_array.rb#test_fetch 
Failure:
TestArray#test_fetch [/home/runner/work/ruby/ruby/src/test/ruby/test_array.rb:2689]:
IndexError expected but nothing was raised.

[-> View Test suite health in main branch]

@byroot byroot force-pushed the array-fetch-values-range branch 3 times, most recently from dbc8508 to 292c45c Compare February 26, 2025 13:08
nobu
nobu reviewed Mar 24, 2025
View reviewed changes
Comment thread array.c Outdated
nobu
nobu reviewed Mar 24, 2025
View reviewed changes
Comment thread array.c
@nobu
Copy link
Copy Markdown
Member

nobu commented Mar 24, 2025

Windows 2022 failure is the VC's bug.

@byroot byroot force-pushed the array-fetch-values-range branch 2 times, most recently from 4c53914 to b301bc0 Compare March 24, 2025 12:58
@byroot byroot force-pushed the array-fetch-values-range branch 2 times, most recently from 32ff80a to a36c4b6 Compare December 17, 2025 07:04
@byroot byroot force-pushed the array-fetch-values-range branch from a36c4b6 to a222a3f Compare December 17, 2025 07:07
@byroot byroot marked this pull request as ready for review December 17, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nobu nobu nobu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@byroot @nobu