[DOC] rb_ary_s_create#11256
Merged
peterzhu2118 merged 2 commits intoruby:masterfrom Jul 29, 2024
BurdetteLamar:rb_ary_s_create_doc
Merged
[DOC] rb_ary_s_create#11256peterzhu2118 merged 2 commits intoruby:masterfrom BurdetteLamar:rb_ary_s_create_doc
peterzhu2118 merged 2 commits intoruby:masterfrom
BurdetteLamar:rb_ary_s_create_doc
Conversation
array.c
Outdated
Comment on lines
+1164
to
+1165
| * Array.[]( 1, 'a', /^A/) # => [1, "a", /^A/] | ||
| * Array.[] # => [] |
Member
There was a problem hiding this comment.
Can we also keep the example using Array[1, 'a', /^A/]? It's the same method call but using different syntax (the most idiomatic syntax).
Member
Author
There was a problem hiding this comment.
Restored (and moved the idiomatic syntax to top).
array.c
Outdated
| * Returns a new array populated with the given objects. | ||
| * Returns a new +Array+ object, populated with the given objects: | ||
| * | ||
| * Array.[]( 1, 'a', /^A/) # => [1, "a", /^A/] |
Member
There was a problem hiding this comment.
Nit: extra space:
Suggested change
| * Array.[]( 1, 'a', /^A/) # => [1, "a", /^A/] | |
| * Array.[](1, 'a', /^A/) # => [1, "a", /^A/] |
Member
Author
There was a problem hiding this comment.
Fixed. (There are no nits.)
peterzhu2118
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tune up Array::[]. Removes two examples that don't actually call Array::[].