Don't root named structs defined in Ruby#10144
Merged
byroot merged 1 commit intoruby:masterfrom Mar 1, 2024
Merged
Conversation
Launchable Report❌ Test session #2670538 failed ❌ Test session #2670601 failed ❌ Test session #2670633 failed Passed test sessions✅ Test session #2670528 passed Build: refs_pull_10144_merge_091e4d445778f424ec2bd29d0440f45560e96135 |
aff1481 to
34fc7b0
Compare
34fc7b0 to
18e41c1
Compare
[Bug #20311]
`rb_define_class_under` assumes it's called from C and that the
reference might be held in a C global variable, so it adds the
class to the VM root.
In the case of `Struct.new('Name')` it's wasteful and make
the struct immortal.
18e41c1 to
091e4d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Bug #20311]
rb_define_class_underassumes it's called from C and that the reference might be held in a C global variable, so it adds the class to the VM root.In the case of
Struct.new('Name')it's wasteful and make the struct immortal.