Skip to content

Fix test for Text.check#166

Merged
kou merged 1 commit into
ruby:masterfrom
Watson1978:fix-text_check-test
Jul 11, 2024
Merged

Fix test for Text.check#166
kou merged 1 commit into
ruby:masterfrom
Watson1978:fix-text_check-test

Conversation

@Watson1978

@Watson1978 Watson1978 commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

This patch will fix incorrect string in a case where unicode characters.
Because of the use of single quotes, it was simply an ASCII string.

@kou

kou commented Jul 11, 2024

Copy link
Copy Markdown
Member

Could you always use " to avoid similar mistakes?

This patch will fix incorrect string in a case where unicode characters.
Because of the use of single quotes, it was simply an ASCII string.
@Watson1978 Watson1978 force-pushed the fix-text_check-test branch from 6059368 to b5763c2 Compare July 11, 2024 09:42
@Watson1978

Copy link
Copy Markdown
Contributor Author

Replaced all ' to " in test_text_check.rb

@kou kou merged commit 87f7cd0 into ruby:master Jul 11, 2024
@kou

kou commented Jul 11, 2024

Copy link
Copy Markdown
Member

Thanks.

@Watson1978 Watson1978 deleted the fix-text_check-test branch July 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants