Merged
Conversation
Contributor
Author
|
Looks like I got distracted and did not finish the other items here. Were they imported some other way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are only a few diffs to resolve in the JRuby version, other than being a bit behind:
lazy_initializelogic exists in both versions. See backport fd leak in resolv jruby/jruby#5524.With only the Windows check fixed, tests pass on JRuby (double-confirmed by replacing JRuby's local copy with the edited version from this repo). I need some assistance from other maintainers as to whether these three PRs need to be ported over. cc @hsbt @nobu
Fixes #19. Once merged and released, JRuby can start shipping resolv as a default gem, rather than a non-gem stdlib.