Merged
Conversation
Currently RBS cannot be used from Bazel or any other tool that builds a forest of symlinks because Gemfile.lock has different path: ``` $ rbs collection install RBS Collection loads a different Gemfile.lock from before. (RBS::Collection::Config::LockfileGenerator::GemfileLockMismatchError) The Gemfile.lock must be the same as that is recorded in rbs_collection.lock.yaml. Expected Gemfile.lock: /private/var/tmp/_bazel_p0deje/d9f7ca256f773f0ccaaf86cfc9fd2df8/execroot/selenium/bazel-out/darwin_arm64-fastbuild/bin/rb/rbs-install.rb.sh.runfiles/selenium/rb/Gemfile.lock Actual Gemfile.lock: /Users/p0deje/Development/SeleniumHQ/selenium/rb/Gemfile.lock ``` This commit would allow to resolve the symlink before attempting to paths.
Contributor
Author
|
Actually, this is not enough because now the Gemfile.lock path is written to the lockfile as a relative path. I would need to figure out the proper way to fix it. |
6 tasks
pocke
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently RBS cannot be used from Bazel or any other tool that builds a forest of symlinks because Gemfile.lock has different path:
This commit would allow to resolve the symlink before attempting to paths.