Fix file path and line number errors when using +, * and ()#273
Merged
yui-knk merged 2 commits intoruby:masterfrom Jul 30, 2024
Merged
Fix file path and line number errors when using +, * and ()#273yui-knk merged 2 commits intoruby:masterfrom
+, * and ()#273yui-knk merged 2 commits intoruby:masterfrom
Conversation
Collaborator
|
Thanks for the PR. I think it's better to add test cases for this pattern. In this case, it's difficult to get line number and file name from actions, so I suggest to add test case in |
This PR fix file path and line number errors when using `+`, `*` or `()`. I discovered this when using the above new grammar in Lrama. Refs: ruby/lrama@df39a6f Refs: https://github.com/ruby/lrama/blob/df39a6f36535ac65e08a0a49eb84d6b944622e22/lib/lrama/parser.rb#L1270-L1282 As it stands, the second argument to `module_eval` is the absolute path to racc/grammarfileparser.rb and the line number. Perhaps specifying `@filename` and` @scanner.lineno + 1` is correct? https://github.com/ydah/racc/blob/ea43e57012355c726b914c52fdcb32708d1091c6/lib/racc/grammarfileparser.rb#L373
7eccc64 to
93b7447
Compare
Member
Author
|
@yui-knk Thank you for your reviewing! I add test case for |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix file path and line number errors when using
+,*or().I discovered this when using the above new grammar in Lrama.
Refs: ruby/lrama@df39a6f
Refs: https://github.com/ruby/lrama/blob/df39a6f36535ac65e08a0a49eb84d6b944622e22/lib/lrama/parser.rb#L1270-L1282
As it stands, the second argument to
module_evalis the absolute path to racc/grammarfileparser.rb and the line number.Perhaps specifying
@filenameand@scanner.lineno + 1is correct?https://github.com/ydah/racc/blob/ea43e57012355c726b914c52fdcb32708d1091c6/lib/racc/grammarfileparser.rb#L373