Merged
Conversation
tompng
commented
Dec 4, 2023
| string.encode(to, from) | ||
| end | ||
|
|
||
| private |
Member
Author
There was a problem hiding this comment.
merge_dump_options should be private instance method and also private module function
module_function
def a_private_instance_method_and_public_module_function
end
private # module_function rule is cleared
def a_private_instance_method # not a module function
end
tompng
commented
Dec 4, 2023
Comment on lines
+618
to
+621
| if anIO.respond_to?(:to_io) | ||
| anIO = anIO.to_io | ||
| elsif limit.nil? && !anIO.respond_to?(:write) | ||
| anIO, limit = nil, anIO |
Member
Author
There was a problem hiding this comment.
Fixed the inconsistency
dump(obj, io, nil) #=> io.to_io was called
dump(obj, io, 10) #=> io.to_io was not calledAnd if to_io is called, the result of to_io should be an IO, no need to check for respond_to?(:write)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed this overload
And fixed this NoMethodError