Skip to content

Reset IOGate.set_winch_handler when dancing ruby easter-egg terminates#1124

Merged
ima1zumi merged 1 commit intoruby:masterfrom
tompng:fix_easter_egg_multiple_times
Oct 16, 2025
Merged

Reset IOGate.set_winch_handler when dancing ruby easter-egg terminates#1124
ima1zumi merged 1 commit intoruby:masterfrom
tompng:fix_easter_egg_multiple_times

Conversation

@tompng
Copy link
Member

@tompng tompng commented Oct 12, 2025

Fix this SystemStackError

irb(main):001> IRB.send(:easter_egg, :dancing)
(CTRL-c)
=> nil
irb(main):002> IRB.send(:easter_egg, :dancing)
(Resize window)
stack level too deep (SystemStackError)
lib/reline/io/ansi.rb:289:in 'block in Reline::ANSI#set_winch_handler'
lib/reline/io/ansi.rb:289:in 'block in Reline::ANSI#set_winch_handler'
lib/reline/io/ansi.rb:289:in 'block in Reline::ANSI#set_winch_handler'
...

IOGate.set_winch_handler needs cleanup: IOGate.deprep(otio) and otio should be a return value of IOGate.prep.
Currently, otio is always nil but may change in the future.

@tompng tompng force-pushed the fix_easter_egg_multiple_times branch from 4a01832 to 967333d Compare October 12, 2025 17:54
ima1zumi
ima1zumi approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ima1zumi ima1zumi merged commit 3893f18 into ruby:master Oct 16, 2025
33 checks passed
@tompng tompng deleted the fix_easter_egg_multiple_times branch October 16, 2025 11:36
@tompng tompng added the bug Something isn't working label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tompng @ima1zumi