Add Row#each_pair #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you want to try adding a test? |
Contributor
Author
|
Thought about it, but I am not sure what is an appropriate amount of testing. It is just an alias, so do you expect me to copy-paste of tests of |
Member
|
This change isn't so simple. What is the expected behavior of the following case? require "csv"
csv = CSV.parse('Bob,100', headers: %i[name salary])
p csv.first.each_pair.to_a
# /tmp/a.rb:3:in `<main>': undefined method `each_pair' for ["Bob", "100"]:Array (NoMethodError) |
Contributor
Author
On my branch: csv.first.each_pair.to_a
# => [[:name, "Bob"], [:salary, "100"]]Is there some problem?.. |
Member
|
Ah, sorry. I pasted wrong code: require "csv"
csv = CSV.parse('Bob,100')
p csv.first.each_pair.to_a |
Member
|
Ah. it's not related with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
Rowtries to quack more-or-less likeHash, andHashhas#each_pair. A practical example where it matters: