Enhanced RDoc for CSV::Table#165
Conversation
esparta
left a comment
There was a problem hiding this comment.
Just questions about inclusion of documentation of by_row! & by_col!, a small typo and a suggestion for variable name -the last completely up to your decision.
lib/csv/table.rb
Outdated
| # headers. Use by_col!() or by_row!() to force the lookup. | ||
| # --- | ||
| # | ||
| # Returns rows as an \Array of \CSV::Row objects: |
There was a problem hiding this comment.
I'm a little confused here; does delete need the example/explanation of by_row! ?
There was a problem hiding this comment.
The by_row! call was not needed in the first place. Removed.
lib/csv/table.rb
Outdated
| # | ||
| # --- | ||
| # | ||
| # Returns columns data as column Arrays: |
There was a problem hiding this comment.
Same for by_row!, maybe a reference would be enough if needed?
There was a problem hiding this comment.
Same as above. Removed.
|
@esparta, the re-request thingy did not work. Please re-review. |
|
@kou, I think this is ready for you. |
Hi @BurdetteLamar, I just re-review and I have no more comments. |
|
Thanks! |
Methods: