doc: fix return value of open {} and use File.open {}#139
doc: fix return value of open {} and use File.open {}#139kou merged 2 commits intoruby:masterfrom BurdetteLamar:rdoc
Conversation
|
@kou, Something's terribly wrong here. The file doc/argument_io.rdoc is not here. I thought it was already merged, along with references to it. How to resolve? |
kou
left a comment
There was a problem hiding this comment.
I think that you just didn't commit doc/argument_io.rdoc.
Could you use more meaningful title for pull request title?
"Enhanced RDoc for CSV" is less meaningful:
- Because this is the repository of CSV. "for CSV" is redundant. All changes are for CSV.
- Because almost document changes are for enhancing document. "Enhanced RDoc" just means "Update document".
I've changed the title of this pull request. It'll help you for the next pull request.
FYI: If we use "... and ..." in the title, it indicates that the pull request includes multiple topics. We should focus on one topic per pull request. In this pull request case, we should create two pull requests, (1) fixing return value of open {} and (2) using File.open {}.
lib/csv.rb
Outdated
| # CSV.foreach(File.open(path)) {|row| p row } # => 21 | ||
| # File.open(path) do |file| | ||
| # CSV.foreach(file) {|row| p row } # => 21 | ||
| # end |
There was a problem hiding this comment.
Should we need to indent this code?
No description provided.