Merged
Conversation
Member
Author
|
@kou, did not mean to merge this. What to do now? |
kou
reviewed
Jun 13, 2020
Member
kou
left a comment
There was a problem hiding this comment.
We can just fix problems by additional commits. :-)
| # | ||
| # Read rows from an \IO object: | ||
| # CSV.foreach(io) {|row| p row } # => 21 | ||
| # CSV.foreach(File.open(path)) {|row| p row } # => 21 |
Member
There was a problem hiding this comment.
We should not use no close File.open in example. It's a bad mannar:
File.open(path) do |input|
CSV.foreach(io) {row p row } # => 21
end
kou
reviewed
Jun 13, 2020
| # open( filename, **options ) | ||
| # open(file_path, mode = "rb", **options ) -> new_csv | ||
| # open(io, mode = "rb", **options ) -> new_csv | ||
| # open(file_path, mode = "rb", **options ) { |csv| ... } -> new_csv |
Member
There was a problem hiding this comment.
It returns the block's return value not the yielded csv instance.
Member
Author
|
Ok, thanks. Will study tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements for open, parse, minor tweaks.