Make CSV::Row#dup return a usable Row (#108)

fastjames · kou · commit 64a1ea06fc4e · 2019-10-22T19:01:24.000+09:00
* Make CSV::Row#dup return a usable Row

Previously, calling `dup` on a `CSV::Row` object yielded an object whose
copy was too shallow. Changing the clone's fields would also change the
fields on the source. This change makes the clone more distinct from the
source, so that changes can be made to its fields without affecting the
source.

* Simplify
diff --git a/lib/csv/row.rb b/lib/csv/row.rb
@@ -50,7 +50,7 @@ def initialize(headers, fields, header_row = false)
 
     def initialize_copy(other)
       super
-      @row = @row.dup
+      @row = @row.collect(&:dup)
     end
 
     # Returns +true+ if this is a header row.
diff --git a/test/csv/test_row.rb b/test/csv/test_row.rb
@@ -425,6 +425,9 @@ def test_dig_cell_no_dig
   def test_dup
     row = CSV::Row.new(["A"], ["foo"])
     dupped_row = row.dup
+    dupped_row["A"] = "bar"
+    assert_equal(["foo", "bar"],
+                 [row["A"], dupped_row["A"]])
     dupped_row.delete("A")
     assert_equal(["foo", nil],
                  [row["A"], dupped_row["A"]])
