Accept no digits in the fractional part#302
Merged
mrkn merged 1 commit intoruby:masterfrom Oct 10, 2024
Merged
Conversation
Member
Author
|
@mrkn What do you think about this? |
Member
|
@kou I'm in favor of this change, but I want to merge this after Ruby's [Feature #20705] is closed. |
Member
Author
|
@mrkn The ticket was closed. |
fix ruby#301 For example, "0.E-9" and "0." are accepted. FYI: `Float()`/`.to_f` will accept "0.E-9": https://bugs.ruby-lang.org/issues/20705 The current `Float` doesn't accept "0." but `.to_f` accepts "0.".
69e80ff to
e01ff7e
Compare
Member
|
@kou Thank you very much! |
Member
Author
|
@mrkn Do you want to release a new version with this so that Ruby 3.4.0 and |
Member
|
Thank you for reminding me. I will do.
Kenta Murata, sent from Gmail Mobile
…On Sun, Dec 15, 2024 at 11:59 Sutou Kouhei ***@***.***> wrote:
@mrkn <https://github.com/mrkn> Do you want to release a new version with
this so that Ruby 3.4.0 and BigDecimal() use the same behavior.
—
Reply to this email directly, view it on GitHub
<#302 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAA653GL6GBGQ43NGRYXJL2FTWA7AVCNFSM6AAAAABNXJPYQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGQZDIMRUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@kou The new version was shipped. |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #301
For example, "0.E-9" and "0." are accepted.
FYI:
Float()/.to_fwill accept "0.E-9":https://bugs.ruby-lang.org/issues/20705
The current
Floatdoesn't accept "0." but.to_faccepts "0.".