Skip to content

Fix some typos#10937

Merged
bbatsov merged 1 commit intorubocop:masterfrom
ydah:fix-spelling
Aug 19, 2022
Merged

Fix some typos#10937
bbatsov merged 1 commit intorubocop:masterfrom
ydah:fix-spelling

Conversation

@ydah
Copy link
Copy Markdown
Member

@ydah ydah commented Aug 19, 2022

This PR is fix some spelling.

  • s/platfoms/platforms/
  • s/directove/directive/
  • s/colmn/column/
  • s/DELIMETER/DELIMITER/
  • s/contant/constant/
  • s/ambigious/ambiguous/
  • s/interporation/interpolation/
  • s/hightlight/highlight/
  • s/specifing/specifying/
  • s/indendation/indentation/
  • s/fileand/file and/
  • s/dedented/indented/
  • s/ofmodule/of module/
  • s/argumnets/arguments/
  • s/alignmenton/alignment on/
  • s/bracketwith/bracket with/
  • s/correcs/corrects/
  • s/accpets/accepts/
  • s/condtionals/conditionals/
  • s/offsense/offense/
  • s/brancheswith/branches with/
  • s/branchsi/branches/
  • s/consntant/constant/
  • s/wheh/when/
  • s/wtyle/style/
  • s/condidate/candidate/
  • s/arguemnt/argument/
  • s/offens/offense/
  • s/offfense/offense/
  • s/condtion/condition/
  • s/rescueing/rescuing/
  • s/commnet/comment/
  • s/parameteres/parameters/
  • s/lodable/loadable/

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • [-] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@ydah ydah changed the title Fix spelling Fix some typos Aug 19, 2022
@koic
Copy link
Copy Markdown
Member

koic commented Aug 19, 2022

I think it is difficult to see the log if I squash because there are many modifications, so I have separated the commits but will squash if necessary.

I won't look at each commit (all spelling mistakes corrected), please squash it.

@koic
Copy link
Copy Markdown
Member

koic commented Aug 19, 2022

And I think it would be better to update the spell checking workflow of GitHub Actions so that this can be detected.
See: #10128

@ydah ydah force-pushed the fix-spelling branch 3 times, most recently from 09bdc75 to 08d685d Compare August 19, 2022 02:49
Comment thread .github/workflows/spell_checking.yml Outdated
Comment thread codespell.txt Outdated
This PR is fix some spelling.
- s/platfoms/platforms/
- s/directove/directive/
- s/colmn/column/
- s/DELIMETER/DELIMITER/
- s/contant/constant/
- s/ambigious/ambiguous/
- s/interporation/interpolation/
- s/hightlight/highlight/
- s/specifing/specifying/
- s/indendation/indentation/
- s/fileand/file and/
- s/dedented/indented/
- s/ofmodule/of module/
- s/argumnets/arguments/
- s/alignmenton/alignment on/
- s/bracketwith/bracket with/
- s/correcs/corrects/
- s/accpets/accepts/
- s/condtionals/conditionals/
- s/offsense/offense/
- s/brancheswith/branches with/
- s/branchsi/branches/
- s/consntant/constant/
- s/wheh/when/
- s/wtyle/style/
- s/condidate/candidate/
- s/arguemnt/argument/
- s/offens/offense/
- s/offfense/offense/
- s/condtion/condition/
- s/rescueing/rescuing/
- s/commnet/comment/
- s/parameteres/parameters/
- s/lodable/loadable/
@ydah
Copy link
Copy Markdown
Member Author

ydah commented Aug 19, 2022

I sent a patch to add some words to the dictionary.

@bbatsov bbatsov merged commit fd5eee4 into rubocop:master Aug 19, 2022
@bbatsov
Copy link
Copy Markdown
Collaborator

bbatsov commented Aug 19, 2022

Nice! How did you manage to identify all those typos?

@ydah ydah deleted the fix-spelling branch August 19, 2022 05:21
@ydah
Copy link
Copy Markdown
Member Author

ydah commented Aug 19, 2022

I often use VSCode and the extension Code Spell Checker to detect and fix them when I find them in the typo fix branch. Once I have accumulated a few, I often check for similar typos in cspell and put them together in a PR. (If we don't put it all together in one PR, there could be a lot of PR for typofixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants