fix: only rewrite docker compose ps/logs/build, skip unsupported (#336)#363
Merged
pszymkowiak merged 1 commit intomasterfrom Mar 6, 2026
Merged
fix: only rewrite docker compose ps/logs/build, skip unsupported (#336)#363pszymkowiak merged 1 commit intomasterfrom
pszymkowiak merged 1 commit intomasterfrom
Conversation
…ommands (#336) The rewrite pattern matched all `docker` commands but the regex didn't cover `docker compose`, so compose subcommands were never rewritten. Meanwhile unsupported compose commands (up, down, config) would fail if manually prefixed with rtk. - Extend regex to match `docker compose (ps|logs|build)` - Unsupported compose subcommands (up, down, config, exec, etc.) are correctly skipped by the regex and not rewritten - 6 new tests covering supported and unsupported compose subcommands Fixes #336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rewrite hook was not handling
docker composesubcommands correctly:ps,logs,build) were not rewritten because the regex only matcheddocker ps|images|logs|...withoutcomposeup,down,config,exec, etc.) were already correctly skippedFix: Extend the regex pattern to also match
docker compose (ps|logs|build).Before / After
docker compose psrtk docker compose ps✅docker compose logs webrtk docker compose logs web✅docker compose buildrtk docker compose build✅docker compose up -ddocker compose downdocker psrtk docker psrtk docker ps✅ (unchanged)Changes
src/discover/rules.rs: Extend regex to coverdocker compose (ps|logs|build)src/discover/registry.rs: 6 new tests for supported and unsupported compose subcommandsTest plan
cargo test— 652 passed, 0 failedrtk docker compose pswith real Docker Compose services — worksrtk docker compose logs— deduplicated outputdocker compose up/down— not rewritten, runs normallyFixes #336
🤖 Generated with Claude Code