-
Notifications
You must be signed in to change notification settings - Fork 338
Closed
Description
Bug Description
rtk pnpm build hardcodes the Next.js output filter for all pnpm build commands, regardless of the actual framework. This causes false error reports on Vite (and likely other non-Next.js) projects.
Steps to Reproduce
- Have a Vite project (not Next.js)
- Run
rtk pnpm build— build succeeds (e.g.✓ built in 5.06s) - RTK reports:
Errors: 1 | Warnings: 0— incorrect - Run bare
pnpm build— no errors shown, only real warnings
Expected Behavior
RTK should detect the build tool being used, or fall back to a generic errors-only passthrough (like rtk err pnpm build) when the framework is not Next.js.
Actual Behavior
RTK always routes pnpm build through next_cmd filter (PnpmCommands::Build -> next_cmd::run), which misparses Vite output and falsely counts warnings or informational messages as errors.
Environment
- RTK version: 0.27.2
- Build tool: Vite v5.4.21
- Package manager: pnpm
Related
- PR feat(pnpm): Add filter argument support #270 includes a side note flagging this exact concern: "the
PnpmCommands::Build -> next_cmd::runseems suspect to me. What if the project uses anything else (vite / rspack / ...)?" - Issue Hook rewrite: add coverage for uv run, pnpm exec, Python path variants, and more #294 proposes routing
pnpm buildto a generic errors-only passthrough instead
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels