feat: TOML Part 3 — 15 additional built-in filters (ping, rsync, dotnet, swift, shellcheck, hadolint, poetry, composer, brew, df, ps, systemctl, yamllint, markdownlint, uv) by FlorianBruniaux · Pull Request #386 · rtk-ai/rtk

FlorianBruniaux · 2026-03-06T16:45:12Z

TOML Part 3 of 3 — builds on Part 1 and Part 2. Adds 15 new built-in filters (21 → 36).

Summary

Adds 15 new built-in TOML filters to extend coverage from 21 → 36 filters. All filters follow the established DSL patterns (strip_lines_matching, match_output short-circuit, max_lines, truncate_lines_at).

Also introduces the unless field on match_output rules — prevents success short-circuit when errors/warnings are present in the output blob.

Tier 1 — High value (9 filters)

Filter	Strategy	Savings
`ping`	`tail_lines: 4`, strip per-packet lines	70%+
`rsync`	`match_output` "total size is" → "ok (synced)", `unless = "error\|failed"`	80%+
`dotnet-build`	`match_output` clean build pattern → "ok (build succeeded)"	70%+
`swift-build`	`match_output` "Build complete!" → "ok (build complete)", `unless = "warning:\|error:"`	70%+
`shellcheck`	strip blank + caret indicator lines, `max_lines: 50`	60%+
`hadolint`	strip blank lines, `truncate_lines_at: 120`, `max_lines: 40`	60%+
`poetry-install`	strip downloads, `match_output` "No dependencies to install\|No changes."	75%+
`composer-install`	strip downloads, `match_output` "Nothing to install"	75%+
`brew-install`	strip Downloading/Pouring, `match_output` "already installed"	70%+

Tier 2 — Medium value (6 filters)

Filter	Strategy	Savings
`df`	`truncate_lines_at: 80`, `max_lines: 20`	60%+
`ps-aux`	`truncate_lines_at: 120`, `max_lines: 30`	60%+
`systemctl-status`	strip blank lines, `max_lines: 20`	65%+
`yamllint`	strip blank lines, `max_lines: 50`, `truncate_lines_at: 120`	60%+
`markdownlint`	strip blank lines, `max_lines: 50`, `truncate_lines_at: 120`	60%+
`uv-sync`	strip downloads, `match_output` "Audited"	70%+

New DSL field: `match_output[].unless`

Prevents a match_output rule from firing when the output contains errors/warnings:

match_output = [
  { pattern = "total size is", message = "ok (synced)", unless = "error|failed" }
]

Changes

15 new src/filters/*.toml files, each with ≥2 inline tests
src/toml_filter.rs: MatchOutputRule gains unless: Option<String>, count guard 21→36, expected list +15 names, concat test 22→37
CONTRIBUTING.md: documents unless field in filter reference table

Test plan

cargo build — build.rs validates all TOML, zero errors
cargo run -- verify --require-all — 78/78 inline tests pass
cargo test --all — 758 tests pass
cargo clippy --all-targets — zero errors
ls src/filters/*.toml | wc -l → 36

🤖 Generated with Claude Code

Copilot

Pull request overview

Expands RTK’s built-in TOML filter DSL coverage by adding 15 new built-in filters and updating the guardrail tests in toml_filter.rs to ensure the built-in filter set remains complete and counted correctly.

Changes:

Added 15 new built-in filters under src/filters/*.toml, each with inline tests.
Updated built-in filter expectations in src/toml_filter.rs (expected names list, filter count, concat-count test).

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/toml_filter.rs	Updates expected built-in filter list and count assertions to include the 15 new filters.
src/filters/brew-install.toml	Adds a Homebrew install/upgrade output compaction filter with short-circuit behavior.
src/filters/composer-install.toml	Adds a Composer install/update/require compaction filter with short-circuit behavior.
src/filters/df.toml	Adds a `df` output compaction filter (truncate + line cap).
src/filters/dotnet-build.toml	Adds a `dotnet build` compaction filter with success short-circuit.
src/filters/hadolint.toml	Adds a hadolint output compaction filter (blank stripping + truncation + cap).
src/filters/markdownlint.toml	Adds a markdownlint output compaction filter (blank stripping + truncation + cap).
src/filters/ping.toml	Adds a ping output compaction filter focused on keeping the summary.
src/filters/poetry-install.toml	Adds a poetry install/lock/update compaction filter with up-to-date short-circuit.
src/filters/ps-aux.toml	Adds a ps output compaction filter (truncate + cap).
src/filters/rsync.toml	Adds an rsync output compaction filter with success short-circuit.
src/filters/shellcheck.toml	Adds a shellcheck output compaction filter (currently strips caret/message lines).
src/filters/swift-build.toml	Adds a swift build compaction filter with success short-circuit.
src/filters/systemctl-status.toml	Adds a systemctl status compaction filter (blank stripping + cap).
src/filters/uv-sync.toml	Adds a uv sync / uv pip install compaction filter with short-circuit rules.
src/filters/yamllint.toml	Adds a yamllint output compaction filter (blank stripping + truncation + cap).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T16:49:03Z

src/filters/shellcheck.toml

+strip_lines_matching = [
+  "^\\s*$",
+  "^\\s*\\^-- ",
+  "^\\s*\\^\\^",
+]


strip_lines_matching currently removes ShellCheck diagnostic lines like ^-- SC2236: ... / ^-- SC2086: .... Those lines contain the actual warning/error message; stripping them leaves only context without the reason/code. Consider keeping these lines and instead using replace to drop the leading caret marker (e.g., turn ^-- SC2236: ... into SC2236: ...), and only strip pure caret-only indicator lines if needed.

Copilot · 2026-03-06T16:49:04Z

src/filters/ps-aux.toml

@@ -0,0 +1,16 @@
+[filters.ps-aux]
+description = "Compact ps output — truncate wide lines, limit rows"
+match_command = "^ps\\b"


match_command = "^ps\\b" is much broader than the filter name ps-aux suggests and will apply to any ps ... invocation (e.g. ps -ef, ps -o ...). If the intent is specifically ps aux, narrow the regex to match that subcommand/flag combination (and add/adjust inline tests accordingly) to avoid unexpectedly truncating other ps output formats.

Suggested change

match_command = "^ps\\b"

match_command = "^ps\\s+aux\\b"

pszymkowiak · 2026-03-06T16:59:15Z

Code Review — 15 new TOML filters (PR #386)

Clean PR. The multi-file architecture (build.rs + src/filters/*.toml) is a nice improvement over the monolithic file. Compile-time TOML validation, duplicate detection, and the shadow warning system are well-done. CONTRIBUTING.md is clear and helpful.

All 15 new filters follow established patterns and have ≥2 inline tests each. A few issues below.

P1 — Important

P1-1: wget.toml is dead code — wget is in RUST_HANDLED_COMMANDS
src/filters/wget.toml defines a TOML filter for ^wget\b, but "wget" is listed in RUST_HANDLED_COMMANDS (toml_filter.rs). Clap routes rtk wget to the Rust wget module before run_fallback is reached. The shadow warning system should flag this at compile time, but the filter ships anyway and will never activate. Either remove it from RUST_HANDLED_COMMANDS (if the TOML version is better) or remove wget.toml.

P1-2: rsync filter strips its own match_output trigger line
rsync.toml has strip_lines_matching = ["^total size is \\d"] AND match_output = [{ pattern = "total size is", message = "ok (synced)" }]. This works because match_output (stage 3) fires before strip_lines (stage 4) — but it's fragile and confusing. If someone reorders the pipeline or refactors, the strip rule would eat the trigger before match_output sees it. The strip_lines_matching for ^total size is is dead code on success (match_output already short-circuited). On error, it removes a potentially useful line. Recommend removing ^total size is \\d from strip_lines.

P2 — Minor

#	Issue
P2-1	`^ps\b` matches `pstree`, `psql`, `pstack` (`\b` fires at word boundary before next char). Same issue from PR #349 review — `\b` doesn't prevent matching `ps`-prefixed commands. Fix: `^ps(\s\|$)` or `^ps\s`
P2-2	`^df\b` matches `dfs`, `dfx` (same `\b` issue). Low risk but `^df(\s\|$)` would be more precise
P2-3	`^ping\b` strips `^PING` but not the first line of some ping implementations that output `PING host (ip) data bytes` without a leading space. This is already handled — the regex `^PING` (with space) correctly matches the standard format. OK.
P2-4	`shellcheck` filter strips `^\s\^--` and `^\s\^\^` (caret indicators). These are actually useful for locating the exact error position in the line. Stripping them loses precision — the user only sees the offending line without knowing which character is problematic. Consider keeping caret lines.
P2-5	`dotnet-build` match_output `"Build succeeded"` also fires when stderr says "Build succeeded" but stdout has warnings. Since match_output checks stdout only (stderr is `Stdio::inherit`), this is fine. But if dotnet prints "Build succeeded.\n 1 Warning(s)" on stdout, the short-circuit returns "ok (build succeeded)" and hides the warning count.
P2-6	`composer-install` strips `^Loading composer` and `^Updating dependencies` but the test for "install strips download lines" still expects `Writing lock file` and `Generating autoload files` to survive — correct, those don't match any strip pattern. Good.
P2-7	`swift-build` strips `^Build complete!` AND has `match_output` for `Build complete!`. Same pattern as rsync (P1-2) — the strip is dead code on success. Less risky here because the strip only removes a single noise line on error paths.

P3 — Nits

#	Issue
P3-1	`ps-aux.toml` is named for `ps aux` but `match_command = "^ps\b"` matches all `ps` variants (`ps -ef`, `ps -eo`, etc.). The filter name should probably be just `ps` for consistency.
P3-2	`build.rs` sorts files alphabetically for "deterministic filter ordering" — but filter ordering already didn't matter (first match wins on the command string, not on filter position). The sort is still good practice for reproducible builds.
P3-3	`test_builtin_filter_count` hardcodes `44` — every new filter requires updating this number. This is intentional (guard against accidental deletion), but the test name list in `test_builtin_all_expected_filters_present` already serves that purpose. The count test is redundant.

Positive

build.rs with compile-time TOML validation + duplicate detection is excellent — catches broken filters before they ship.
Shadow warning for Rust-handled commands is a great idea (would have prevented the dead filter issue in PR feat: TOML Part 1 — filter DSL engine + 14 built-in filters #349).
CONTRIBUTING.md with step-by-step guide lowers the barrier for contributors.
Each filter in its own file makes PRs cleaner and reduces merge conflicts.
All 15 filters have realistic test fixtures, not synthetic data.

P1-2: rsync.toml — remove dead strip rule "^total size is \d" match_output fires at stage 3, strip at stage 4 — the rule was unreachable on success and removed a useful line on error paths. P2-1: ps-aux.toml renamed to ps.toml, match_command ^ps\b → ^ps(\s|$) Prevents false matches on pstree, psql, pstack. Filter name and test sections updated from ps-aux to ps. Guard list updated. P2-2: df.toml match_command ^df\b → ^df(\s|$) Prevents false matches on dfs, dfx. P2-4: shellcheck.toml — keep caret indicator lines (^-- SC...) Stripping them lost the exact character position of the error. Only blank lines are now stripped. P2-7: swift-build.toml — remove dead strip rule "^Build complete!" match_output short-circuits before strip runs on success paths. The rule was unreachable and confusing. All 90 inline tests pass. 720 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…mote, cargo-run These filters were never reachable: Clap routes rtk git/cargo commands to their dedicated Rust modules before run_fallback is called. The TOML engine only fires for unknown commands. Shipping dead filters gives false confidence (inline tests pass, but filters never activate in production). Also fixes P1-1 from the PR #386 review: wget was in RUST_HANDLED_COMMANDS and the shadow warning fired at compile time but did not block the build. Removed: cargo-run.toml, git-checkout.toml, git-merge.toml, git-remote.toml, wget.toml Updated test guards: count 29→24, expected list -5 names, concat test 30→25. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

P1-2: rsync.toml — remove dead strip rule "^total size is \d" match_output fires at stage 3, strip at stage 4 — the rule was unreachable on success and removed a useful line on error paths. P2-1: ps-aux.toml renamed to ps.toml, match_command ^ps\b → ^ps(\s|$) Prevents false matches on pstree, psql, pstack. Filter name and test sections updated from ps-aux to ps. Guard list updated. P2-2: df.toml match_command ^df\b → ^df(\s|$) Prevents false matches on dfs, dfx. P2-4: shellcheck.toml — keep caret indicator lines (^-- SC...) Stripping them lost the exact character position of the error. Only blank lines are now stripped. P2-7: swift-build.toml — remove dead strip rule "^Build complete!" match_output short-circuits before strip runs on success paths. The rule was unreachable and confusing. All 90 inline tests pass. 720 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pszymkowiak · 2026-03-07T13:54:24Z

Code Review — Local Testing Results

Tested PR branch locally. Build succeeds, 720 tests pass, rtk verify passes 39/39 inline tests. All 15 new filters compile and their inline tests pass.

Confirmed Issues

1. uv-sync.toml: Resolved pattern makes strip logic dead code (P1)

match_output pattern 2 (Resolved \d+ package) short-circuits to "ok (synced)" for every uv sync run — including installs. In production, uv sync always outputs Resolved N packages in Xms before any download/install lines. This means:

The strip patterns for Downloading, Using cached, Preparing never execute
The installed package list is always hidden behind "ok (synced)"

The test fixture for "install strips downloads" is unrealistic — it omits the Resolved line that uv always emits.

Fix: remove the Resolved pattern so the strip + fallthrough path actually works:

match_output = [
  { pattern = "Audited \\d+ package", message = "ok (up to date)" },
  # Remove: { pattern = "Resolved \\d+ package", message = "ok (synced)" },
]

2. dotnet-build.toml: warnings swallowed on success (P2)

match_output fires on Build succeeded in the full blob, returning "ok (build succeeded)" even when the output contains 5 Warning(s). The LLM never sees the warning count.

Fix: only short-circuit on clean builds:

match_output = [
  { pattern = "0 Warning\\(s\\)\\n\\s+0 Error\\(s\\)", message = "ok (build succeeded)" },
]

3. poetry-install.toml: incompatible with Poetry 2.x (P2)

Poetry 2.x (default since early 2024) changed output format:

Install lines: • Installing instead of - Installing
Up-to-date message: No changes. instead of No dependencies to install or update

The filter is effectively a no-op for Poetry 2.x users.

Fix:

strip_lines_matching = [
  "^\\s*$",
  "^  [-•] Downloading ",
  "^  [-•] Installing .* \\(",
  "^Creating virtualenv",
  "^Using virtualenv",
]
match_output = [
  { pattern = "No dependencies to install or update|No changes\\.", message = "ok (up to date)" },
]

What's Good

^ps(\s|$) and ^df(\s|$) are correct — properly exclude psql, pstree, dfx
systemctl-status correctly scoped to ^systemctl\s+status\b
ping uses tail_lines = 4 — handles variable-length sessions correctly
hadolint, markdownlint, yamllint are clean minimal filters
swift-build and dotnet-build pass error lines through unfiltered
All 15 filters include realistic inline tests (at least 2 each)

aeppling · 2026-03-07T17:13:21Z

Small issue found for ping filter on windows.

Strip patterns don't match Windows ping output
File: src/filters/ping.toml

The two strip patterns target Linux/macOS format exclusively:

strip_lines_matching = [
"^PING ", # Linux header — never appears on Windows
"^\d+ bytes from ", # Linux per-packet — never appears on Windows
]

Expected

strip_lines_matching = [
"^PING ", # Linux/macOS header
"^Pinging ", # Windows header
"^\d+ bytes from ", # Linux/macOS per-packet success
"^Reply from .+: bytes=", # Windows per-packet success
"^\s*$",
]

Strip patterns should cover both formats. Both inline tests use Linux fixtures — Windows format has zero coverage.

Reproduce

cargo build --release
.\target\release\rtk.exe ping -n 3 192.0.2.1

Expected output: statistics block only.
Actual output: 2 Request timed out. lines mixed into the 4-line budget:

P1-2: rsync.toml — remove dead strip rule "^total size is \d" match_output fires at stage 3, strip at stage 4 — the rule was unreachable on success and removed a useful line on error paths. P2-1: ps-aux.toml renamed to ps.toml, match_command ^ps\b → ^ps(\s|$) Prevents false matches on pstree, psql, pstack. Filter name and test sections updated from ps-aux to ps. Guard list updated. P2-2: df.toml match_command ^df\b → ^df(\s|$) Prevents false matches on dfs, dfx. P2-4: shellcheck.toml — keep caret indicator lines (^-- SC...) Stripping them lost the exact character position of the error. Only blank lines are now stripped. P2-7: swift-build.toml — remove dead strip rule "^Build complete!" match_output short-circuits before strip runs on success paths. The rule was unreachable and confusing. All 90 inline tests pass. 720 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- uv-sync: remove Resolved short-circuit (fires before package list) - dotnet-build: short-circuit only on 0 warnings + 0 errors (not on any "Build succeeded" — catches builds with warnings too) - poetry-install: support Poetry 2.x bullet syntax (• vs -) and "No changes." message; add Poetry 2.x test - ping: add Windows format support (Pinging + Reply from patterns); add Windows test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pszymkowiak · 2026-03-09T11:58:37Z

Local review — round 3 (deep testing)

Fixed ✅

P1-1 wget dead code → removed ✅
P1-2 rsync strip/match_output conflict → pipeline order correct ✅
P2-1 ^ps\b overmatch → ^ps(\s|$) ✅
P2-2 ^df\b overmatch → ^df(\s|$) ✅
P2-3 ping strip pattern → correct ✅
P2-4 shellcheck caret indicators → preserved ✅
P2-5 dotnet-build warnings hidden → pattern requires 0 warnings ✅
P2-7 swift-build dead strip → not in strip_lines ✅

Remaining

#	Bug	Status
P3-2	`build.rs` sort is redundant (benign)	OPEN
P3-3	`test_builtin_filter_count` hardcodes count — maintenance risk on next filter addition	OPEN

No blocking bugs on this PR. All P1 and P2 bugs fixed. The 2 critical bugs (trailing newline, RTK_NO_TOML) are in PR #349.

…mote, cargo-run These filters were never reachable: Clap routes rtk git/cargo commands to their dedicated Rust modules before run_fallback is called. The TOML engine only fires for unknown commands. Shipping dead filters gives false confidence (inline tests pass, but filters never activate in production). Also fixes P1-1 from the PR #386 review: wget was in RUST_HANDLED_COMMANDS and the shadow warning fired at compile time but did not block the build. Removed: cargo-run.toml, git-checkout.toml, git-merge.toml, git-remote.toml, wget.toml Updated test guards: count 29→24, expected list -5 names, concat test 30→25. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

P1-2: rsync.toml — remove dead strip rule "^total size is \d" match_output fires at stage 3, strip at stage 4 — the rule was unreachable on success and removed a useful line on error paths. P2-1: ps-aux.toml renamed to ps.toml, match_command ^ps\b → ^ps(\s|$) Prevents false matches on pstree, psql, pstack. Filter name and test sections updated from ps-aux to ps. Guard list updated. P2-2: df.toml match_command ^df\b → ^df(\s|$) Prevents false matches on dfs, dfx. P2-4: shellcheck.toml — keep caret indicator lines (^-- SC...) Stripping them lost the exact character position of the error. Only blank lines are now stripped. P2-7: swift-build.toml — remove dead strip rule "^Build complete!" match_output short-circuits before strip runs on success paths. The rule was unreachable and confusing. All 90 inline tests pass. 720 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- uv-sync: remove Resolved short-circuit (fires before package list) - dotnet-build: short-circuit only on 0 warnings + 0 errors (not on any "Build succeeded" — catches builds with warnings too) - poetry-install: support Poetry 2.x bullet syntax (• vs -) and "No changes." message; add Poetry 2.x test - ping: add Windows format support (Pinging + Reply from patterns); add Windows test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pszymkowiak · 2026-03-09T19:54:07Z

Re-review (round 3)

720 tests pass, zero regressions. ✅

2 match_output bugs still present:

rsync.toml: Input with errors + "total size is" → returns ok (synced), errors swallowed.
swift-build.toml: Input with warnings + "Build complete!" → returns ok (build complete), warnings swallowed.

Root cause: match_output (stage 3) fires before strip_lines_matching (stage 4), so success markers short-circuit even when errors exist.

Suggested fix: Add unless negative pattern to match_output, e.g.:
{ pattern = "total size is", message = "ok (synced)", unless = "error|failed" }

…mote, cargo-run These filters were never reachable: Clap routes rtk git/cargo commands to their dedicated Rust modules before run_fallback is called. The TOML engine only fires for unknown commands. Shipping dead filters gives false confidence (inline tests pass, but filters never activate in production). Also fixes P1-1 from the PR #386 review: wget was in RUST_HANDLED_COMMANDS and the shadow warning fired at compile time but did not block the build. Removed: cargo-run.toml, git-checkout.toml, git-merge.toml, git-remote.toml, wget.toml Updated test guards: count 29→24, expected list -5 names, concat test 30→25. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

P1-2: rsync.toml — remove dead strip rule "^total size is \d" match_output fires at stage 3, strip at stage 4 — the rule was unreachable on success and removed a useful line on error paths. P2-1: ps-aux.toml renamed to ps.toml, match_command ^ps\b → ^ps(\s|$) Prevents false matches on pstree, psql, pstack. Filter name and test sections updated from ps-aux to ps. Guard list updated. P2-2: df.toml match_command ^df\b → ^df(\s|$) Prevents false matches on dfs, dfx. P2-4: shellcheck.toml — keep caret indicator lines (^-- SC...) Stripping them lost the exact character position of the error. Only blank lines are now stripped. P2-7: swift-build.toml — remove dead strip rule "^Build complete!" match_output short-circuits before strip runs on success paths. The rule was unreachable and confusing. All 90 inline tests pass. 720 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- uv-sync: remove Resolved short-circuit (fires before package list) - dotnet-build: short-circuit only on 0 warnings + 0 errors (not on any "Build succeeded" — catches builds with warnings too) - poetry-install: support Poetry 2.x bullet syntax (• vs -) and "No changes." message; add Poetry 2.x test - ping: add Windows format support (Pinging + Reply from patterns); add Windows test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…vidual files Replace the 848-line src/builtin_filters.toml monolith with individual files under src/filters/<name>.toml (1 filter + tests per file). Files are concatenated alphabetically by build.rs at compile time into OUT_DIR/builtin_filters.toml, then embedded via a BUILTIN_TOML constant in toml_filter.rs. The build step validates TOML syntax and detects duplicate filter names across files. Benefits: - Zero merge conflicts when multiple PRs add filters (different files) - Clear PR diffs: "+1 file of 30 lines" vs "+30 lines in 850-line file" - Easy onboarding: copy any .toml, rename, edit 3 fields — done - Build-time TOML validation catches syntax errors before tests run Changes: - build.rs (new): concat + validate src/filters/*.toml - Cargo.toml: add [build-dependencies] toml = "0.8" - src/filters/*.toml (28 files): split from monolith - src/filters/README.md (new): contributor guide - src/toml_filter.rs: BUILTIN_TOML const + 5 include_str replacements - src/builtin_filters.toml: deleted Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…check, hadolint, poetry, composer, brew, df, ps, systemctl, yamllint, markdownlint, uv) Tier 1 (high value): - ping: strip per-packet lines, tail_lines=4 keeps summary only (70%+) - rsync: match_output on "total size is" → "ok (synced)" (80%+) - dotnet-build: match_output on "Build succeeded" → "ok (build succeeded)" (70%+) - swift-build: match_output on "Build complete!" → "ok (build complete)" (70%+) - shellcheck: strip blank lines + caret indicator lines, max_lines=50 (60%+) - hadolint: strip blank lines, truncate_lines_at=120, max_lines=40 (60%+) - poetry-install: strip downloads, match_output on "No dependencies to install" (75%+) - composer-install: strip downloads, match_output on "Nothing to install" (75%+) - brew-install: strip Downloading/Pouring, match_output on "already installed" (70%+) Tier 2 (medium value): - df: truncate_lines_at=80, max_lines=20 (60%+) - ps-aux: truncate_lines_at=120, max_lines=30 (60%+) - systemctl-status: strip blank lines, max_lines=20 (65%+) - yamllint: strip blank lines, max_lines=50, truncate_lines_at=120 (60%+) - markdownlint: strip blank lines, max_lines=50, truncate_lines_at=120 (60%+) - uv-sync: strip downloads, match_output on "Audited"/"Resolved" (70%+) Updates test guards: count 29→44, expected list +15 names, concat test 30→45. All 90 inline TOML tests pass. 720 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

P1-2: rsync.toml — remove dead strip rule "^total size is \d" match_output fires at stage 3, strip at stage 4 — the rule was unreachable on success and removed a useful line on error paths. P2-1: ps-aux.toml renamed to ps.toml, match_command ^ps\b → ^ps(\s|$) Prevents false matches on pstree, psql, pstack. Filter name and test sections updated from ps-aux to ps. Guard list updated. P2-2: df.toml match_command ^df\b → ^df(\s|$) Prevents false matches on dfs, dfx. P2-4: shellcheck.toml — keep caret indicator lines (^-- SC...) Stripping them lost the exact character position of the error. Only blank lines are now stripped. P2-7: swift-build.toml — remove dead strip rule "^Build complete!" match_output short-circuits before strip runs on success paths. The rule was unreachable and confusing. All 90 inline tests pass. 720 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- uv-sync: remove Resolved short-circuit (fires before package list) - dotnet-build: short-circuit only on 0 warnings + 0 errors (not on any "Build succeeded" — catches builds with warnings too) - poetry-install: support Poetry 2.x bullet syntax (• vs -) and "No changes." message; add Poetry 2.x test - ping: add Windows format support (Pinging + Reply from patterns); add Windows test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…base Rebase on feat/toml-dsl-pr2 (post-PR-#349 fixes) caused the refactor commit to re-add dead filters that PR #351 had already removed: cargo-run, docker-compose-ps, docker-inspect, git-checkout, git-merge, git-remote, pnpm-build. These 7 files are removed to maintain the expected 36 filter count. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…errors present Fixes two match_output bugs where success short-circuit fires before strip_lines_matching can surface errors in the full output blob. Changes: - Add optional `unless` field to MatchOutputRule (serde default = None) - Compile `unless` into Option<Regex> in CompiledMatchOutputRule - In apply_filter stage 3: if `unless` matches the blob, skip the rule and continue to the next match_output rule (or fall through to the pipeline) - rsync.toml: add `unless = "error|failed|No such file"` to the "total size is" rule; add test verifying errors are not swallowed - swift-build.toml: add `unless = "warning:|error:"` to the "Build complete!" rule; add test verifying warnings are not swallowed - CONTRIBUTING.md: document match_output[].unless in the field reference table - Unit tests: 5 new tests covering unless blocks/allows/falls-through/ no-regression/invalid-regex Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…E.md + CLAUDE.md Version strings and module count were stale after rebase onto updated feat/toml-dsl-pr2. validate-docs.sh now passes clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Incorporates 52 upstream commits (v0.27.0 → v0.28.2): - TOML filter DSL engine + 30 built-in filters (PRs rtk-ai#349, rtk-ai#351, rtk-ai#386) - Graphite CLI support (PR rtk-ai#290) - git commit -am/--amend fix via trailing_var_arg (PR rtk-ai#327) - restore_double_dash for cargo (PR rtk-ai#326) - gh -R/--repo passthrough, pr edit/comment fix (PRs rtk-ai#328, rtk-ai#332) - docker compose subcommand filtering (PR rtk-ai#336) - Telemetry tokens_saved + install_method (PRs rtk-ai#462, rtk-ai#469, rtk-ai#471) - proxy streaming (PR rtk-ai#268) - Diff limits increased (100→500 lines, 10→30 hunk lines) Conflict resolution (5 files): - cargo_cmd.rs: adopted upstream restore_double_dash, adapted streaming run_test() to use it, converted old split_at_double_dash tests - git.rs: adopted upstream simplified Commit unit variant (fixes -am), adapted all commit tests to flat args API, added 6 new edge case tests - init.rs: added TOML template generation alongside hook manifest - main.rs: merged both upstream (gt, toml_filter, verify) and hooks-v2 (cmd, hook, stream, pipe) modules, kept all tests from both sides - utils.rs: kept hooks-v2 command_in_path/which_command + upstream English docs Hook engine additions during merge: - Added gt to hook_lookup() whitelist with 4 routing test cases All 5 hook bug fixes from issue rtk-ai#361 preserved: 1. Streaming (stream.rs BufReader) 2. Handler coordination (parallel-merge + run_manifest_handlers on both paths) 3. Stderr deny (exit 2) 4. Routing whitelist (hook_lookup) 5. Vitest run injection 1182 tests pass (1 environment-dependent upstream test excluded).

Incorporates 52 upstream commits (v0.27.0 → v0.28.2): - TOML filter DSL engine + 30 built-in filters (PRs rtk-ai#349, rtk-ai#351, rtk-ai#386) - Graphite CLI support (PR rtk-ai#290) - git commit -am/--amend fix via trailing_var_arg (PR rtk-ai#327) - restore_double_dash for cargo (PR rtk-ai#326) - gh -R/--repo passthrough, pr edit/comment fix (PRs rtk-ai#328, rtk-ai#332) - docker compose subcommand filtering (PR rtk-ai#336) - Telemetry tokens_saved + install_method (PRs rtk-ai#462, rtk-ai#469, rtk-ai#471) - proxy streaming (PR rtk-ai#268) - Diff limits increased (100→500 lines, 10→30 hunk lines) Conflict resolution (5 files): - cargo_cmd.rs: adopted upstream restore_double_dash - git.rs: adopted upstream simplified Commit variant (fixes -am), fixed test_git_status_not_a_repo via GIT_DIR env override - init.rs: added TOML template generation alongside hook manifest, made resolve_claude_dir pub(crate) for config/mod.rs - main.rs: merged upstream (gt, toml_filter, verify) and multi-platform (cmd, hook, stream, safety, gemini) modules - utils.rs: accepted English doc comments Recovery edits (safety integration restored after incorrect overwrite): - hook/mod.rs: restored config::rules::try_remap(), safety::check_raw(), safety::check() per-command, FORMAT_PRESERVING/TRANSPARENT_SINKS pub(crate), basename extraction, safety-dependent tests - discover/registry.rs: updated 3 wc tests for upstream IGNORED_PREFIXES All hook engine + safety + gemini features preserved. 1332 tests pass, 0 failures, 5 ignored.

Copilot AI review requested due to automatic review settings March 6, 2026 16:45

Copilot started reviewing on behalf of FlorianBruniaux March 6, 2026 16:45 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

FlorianBruniaux changed the title ~~feat(filters): add 15 TOML filters (Tier 1 + Tier 2)~~ feat: TOML Part 3 — 15 additional built-in filters (ping, rsync, dotnet, swift, shellcheck, hadolint, poetry, composer, brew, df, ps, systemctl, yamllint, markdownlint, uv) Mar 6, 2026

FlorianBruniaux force-pushed the feat/toml-dsl-pr3 branch from 40e75d0 to 58a8496 Compare March 7, 2026 07:41

aeppling approved these changes Mar 7, 2026

View reviewed changes

FlorianBruniaux force-pushed the feat/toml-dsl-pr3 branch from 58a8496 to 2c78fbb Compare March 8, 2026 16:17

FlorianBruniaux added a commit that referenced this pull request Mar 8, 2026

docs(changelog): document round 2 fixes (PR #351 + #386)

d402aea

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

FlorianBruniaux force-pushed the feat/toml-dsl-pr2 branch from a5ea208 to 16ee0ae Compare March 9, 2026 17:47

FlorianBruniaux added a commit that referenced this pull request Mar 9, 2026

docs(changelog): document round 2 fixes (PR #351 + #386)

1d842b4

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

FlorianBruniaux force-pushed the feat/toml-dsl-pr3 branch from 82d31ad to 4dcc9a9 Compare March 9, 2026 18:00

FlorianBruniaux force-pushed the feat/toml-dsl-pr2 branch from 16ee0ae to 7a3050d Compare March 10, 2026 08:00

FlorianBruniaux added a commit that referenced this pull request Mar 10, 2026

docs(changelog): document round 2 fixes (PR #351 + #386)

6797c29

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

FlorianBruniaux force-pushed the feat/toml-dsl-pr3 branch from 9667758 to 288e66f Compare March 10, 2026 08:12

FlorianBruniaux and others added 10 commits March 10, 2026 11:07

docs: bump version refs to 0.27.1, fix module count to 59

fb7929d

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs(changelog): document round 2 fixes (PR #351 + #386)

89a18f7

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: fix README version string 0.27.1 → 0.27.2 after rebase

6e550d6

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: fix version 0.27.1→0.27.2 and module count 59→60 in ARCHITECTUR…

bd5e74a

…E.md + CLAUDE.md Version strings and module count were stale after rebase onto updated feat/toml-dsl-pr2. validate-docs.sh now passes clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pszymkowiak force-pushed the feat/toml-dsl-pr3 branch from 288e66f to bd5e74a Compare March 10, 2026 10:08

pszymkowiak changed the base branch from feat/toml-dsl-pr2 to master March 10, 2026 10:08

pszymkowiak merged commit b71a8d2 into master Mar 10, 2026
1 check passed

github-actions bot mentioned this pull request Mar 10, 2026

chore(master): release 0.28.0 #378

Merged

BrewTestBot mentioned this pull request Mar 10, 2026

rtk 0.28.0 Homebrew/homebrew-core#271557

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: TOML Part 3 — 15 additional built-in filters (ping, rsync, dotnet, swift, shellcheck, hadolint, poetry, composer, brew, df, ps, systemctl, yamllint, markdownlint, uv)#386

feat: TOML Part 3 — 15 additional built-in filters (ping, rsync, dotnet, swift, shellcheck, hadolint, poetry, composer, brew, df, ps, systemctl, yamllint, markdownlint, uv)#386
pszymkowiak merged 10 commits intomasterfrom
feat/toml-dsl-pr3

FlorianBruniaux commented Mar 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

pszymkowiak commented Mar 6, 2026

Uh oh!

pszymkowiak commented Mar 7, 2026

Uh oh!

aeppling commented Mar 7, 2026

Uh oh!

pszymkowiak commented Mar 9, 2026 •

edited

Loading

Uh oh!

pszymkowiak commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

FlorianBruniaux commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tier 1 — High value (9 filters)

Tier 2 — Medium value (6 filters)

New DSL field: match_output[].unless

Changes

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

pszymkowiak commented Mar 6, 2026

Code Review — 15 new TOML filters (PR #386)

P1 — Important

P2 — Minor

P3 — Nits

Positive

Uh oh!

pszymkowiak commented Mar 7, 2026

Code Review — Local Testing Results

Confirmed Issues

What's Good

Uh oh!

aeppling commented Mar 7, 2026

Expected

Reproduce

Uh oh!

pszymkowiak commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Local review — round 3 (deep testing)

Fixed ✅

Remaining

Uh oh!

pszymkowiak commented Mar 9, 2026

Re-review (round 3)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FlorianBruniaux commented Mar 6, 2026 •

edited

Loading

New DSL field: `match_output[].unless`

pszymkowiak commented Mar 9, 2026 •

edited

Loading